Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 9741001: DOMUI: Remove experimental sync promo layouts (Closed)

Created:
8 years, 9 months ago by sail
Modified:
8 years, 9 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

DOMUI: Remove experimental sync promo layouts This is the DOMUI part of removing experimental sync promo layouts. With this change we keep layout 3 and remove all the other layouts. The C++ part of this work is here: http://codereview.chromium.org/9730021/ BUG=119014 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128171

Patch Set 1 #

Patch Set 2 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, -406 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +0 lines, -54 lines 0 comments Download
D chrome/app/theme/chromium/sync_promo_info_graphic.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/chromium/sync_promo_info_graphic_1.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 2 chunks +0 lines, -4 lines 0 comments Download
D chrome/browser/resources/shared/images/google-logo-41.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/shared/images/google-mail.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/shared/images/sync.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/shared/images/sync-backup.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/shared_resources.grd View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/resources/sync_promo/sync_promo.css View 3 chunks +3 lines, -207 lines 0 comments Download
M chrome/browser/resources/sync_promo/sync_promo.js View 5 chunks +1 line, -59 lines 0 comments Download
M chrome/browser/resources/sync_setup_overlay.html View 2 chunks +0 lines, -48 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_handler2.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 3 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
sail
8 years, 9 months ago (2012-03-20 02:19:07 UTC) #1
Dan Beam
lgtm (so are we just not offering users a way to learn more at all, ...
8 years, 9 months ago (2012-03-20 20:47:52 UTC) #2
sail
On 2012/03/20 20:47:52, Dan Beam wrote: > lgtm (so are we just not offering users ...
8 years, 9 months ago (2012-03-20 21:13:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/9741001/2001
8 years, 9 months ago (2012-03-21 01:34:20 UTC) #4
commit-bot: I haz the power
Presubmit check for 9741001-2001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-03-21 01:34:30 UTC) #5
sail
jhawkins: could I get OWNERS review for browser/resources/* and ui/webui/*
8 years, 9 months ago (2012-03-21 18:48:44 UTC) #6
Dan Beam
On 2012/03/21 18:48:44, sail wrote: > jhawkins: could I get OWNERS review for browser/resources/* and ...
8 years, 9 months ago (2012-03-21 19:24:23 UTC) #7
sail
On 2012/03/21 19:24:23, Dan Beam wrote: > On 2012/03/21 18:48:44, sail wrote: > > jhawkins: ...
8 years, 9 months ago (2012-03-21 19:27:50 UTC) #8
sail
Spamming other OWNERS arv, estade, csilv: could I get a quick OWNERS review for ui/webui/*
8 years, 9 months ago (2012-03-21 19:28:20 UTC) #9
csilv
lgtm
8 years, 9 months ago (2012-03-21 20:08:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/9741001/2001
8 years, 9 months ago (2012-03-21 21:16:54 UTC) #11
commit-bot: I haz the power
8 years, 9 months ago (2012-03-21 21:29:26 UTC) #12
Try job failure for 9741001-2001 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698