Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8085)

Unified Diff: chrome/browser/ui/webui/print_preview/extension_printer_handler.h

Issue 973993003: Instead of ArrayBuffer, pass blob with printerProvider.onPrintRequested (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase & add ext fun histogram Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/print_preview/extension_printer_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/print_preview/extension_printer_handler.h
diff --git a/chrome/browser/ui/webui/print_preview/extension_printer_handler.h b/chrome/browser/ui/webui/print_preview/extension_printer_handler.h
index 408c4bce62d120c4d01e49c8fd776a6f4523f820..b236407bfda3327d68873564aaec363f72117ae8 100644
--- a/chrome/browser/ui/webui/print_preview/extension_printer_handler.h
+++ b/chrome/browser/ui/webui/print_preview/extension_printer_handler.h
@@ -40,8 +40,8 @@ class PWGRasterConverter;
// extension API.
class ExtensionPrinterHandler : public PrinterHandler {
public:
- using RefCountedMemoryCallback =
- base::Callback<void(const scoped_refptr<base::RefCountedMemory>&)>;
+ using PrintJobCallback =
+ base::Callback<void(scoped_ptr<extensions::PrinterProviderPrintJob>)>;
ExtensionPrinterHandler(
content::BrowserContext* browser_context,
@@ -78,13 +78,13 @@ class ExtensionPrinterHandler : public PrinterHandler {
const cloud_devices::CloudDeviceDescription& printer_description,
const cloud_devices::CloudDeviceDescription& ticket,
const gfx::Size& page_size,
- const RefCountedMemoryCallback& callback);
+ scoped_ptr<extensions::PrinterProviderPrintJob> job,
+ const PrintJobCallback& callback);
// Sets print job document data and dispatches it using printerProvider API.
void DispatchPrintJob(
const PrinterHandler::PrintCallback& callback,
- scoped_ptr<extensions::PrinterProviderPrintJob> print_job,
- const scoped_refptr<base::RefCountedMemory>& data);
+ scoped_ptr<extensions::PrinterProviderPrintJob> print_job);
// Methods used as wrappers to callbacks for extensions::PrinterProviderAPI
// methods, primarily so the callbacks can be bound to this class' weak ptr.
« no previous file with comments | « no previous file | chrome/browser/ui/webui/print_preview/extension_printer_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698