Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 973403002: Address NewApi warnings in src/ui. (Closed)

Created:
5 years, 9 months ago by newt (away)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Address NewApi warnings in src/ui. TBR=nyquist@chromium.org BUG=411461 Committed: https://crrev.com/e1b73c98eaba4771465e46cae7b8563afd3f7260 Cr-Commit-Position: refs/heads/master@{#319182}

Patch Set 1 #

Total comments: 3

Patch Set 2 : removed SetDefaultBufferSize from .h file #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -33 lines) Patch
M base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/ColorPickerAdvancedComponent.java View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/Clipboard.java View 1 2 5 chunks +11 lines, -4 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/gfx/DeviceDisplayInfo.java View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/gl/SurfaceTexturePlatformWrapper.java View 1 2 4 chunks +5 lines, -6 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/widget/TextViewWithClickableSpans.java View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/gl/android/surface_texture.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gl/android/surface_texture.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
newt (away)
PTAL sievers: SurfaceTexturePlatformWrapper.java and surface_texture.cc dtrainor: other files
5 years, 9 months ago (2015-03-04 01:40:16 UTC) #2
newt (away)
https://codereview.chromium.org/973403002/diff/1/ui/gl/android/surface_texture.cc File ui/gl/android/surface_texture.cc (left): https://codereview.chromium.org/973403002/diff/1/ui/gl/android/surface_texture.cc#oldcode90 ui/gl/android/surface_texture.cc:90: void SurfaceTexture::SetDefaultBufferSize(int width, int height) { This method hasn't ...
5 years, 9 months ago (2015-03-04 01:41:02 UTC) #3
no sievers
lgtm w/1 comment https://codereview.chromium.org/973403002/diff/1/ui/gl/android/surface_texture.cc File ui/gl/android/surface_texture.cc (left): https://codereview.chromium.org/973403002/diff/1/ui/gl/android/surface_texture.cc#oldcode90 ui/gl/android/surface_texture.cc:90: void SurfaceTexture::SetDefaultBufferSize(int width, int height) { ...
5 years, 9 months ago (2015-03-04 17:54:04 UTC) #4
David Trainor- moved to gerrit
lgtm
5 years, 9 months ago (2015-03-04 23:18:20 UTC) #5
newt (away)
https://chromiumcodereview.appspot.com/973403002/diff/1/ui/gl/android/surface_texture.cc File ui/gl/android/surface_texture.cc (left): https://chromiumcodereview.appspot.com/973403002/diff/1/ui/gl/android/surface_texture.cc#oldcode90 ui/gl/android/surface_texture.cc:90: void SurfaceTexture::SetDefaultBufferSize(int width, int height) { On 2015/03/04 17:54:04, ...
5 years, 9 months ago (2015-03-04 23:25:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973403002/20001
5 years, 9 months ago (2015-03-04 23:26:56 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/65588)
5 years, 9 months ago (2015-03-04 23:51:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973403002/40001
5 years, 9 months ago (2015-03-05 00:04:55 UTC) #15
nyquist
base/android lgtm
5 years, 9 months ago (2015-03-05 00:38:04 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-05 01:05:23 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 01:06:20 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e1b73c98eaba4771465e46cae7b8563afd3f7260
Cr-Commit-Position: refs/heads/master@{#319182}

Powered by Google App Engine
This is Rietveld 408576698