Issue 9733025: NULL check GetFocusManager() before using it in ChromeWebContentsViewDelegateWin::StoreFocus().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9733025: NULL check GetFocusManager() before using it in ChromeWebContentsViewDelegateWin::StoreFocus(). (Closed)

Created:
8 years, 9 months ago by jam

Modified:
8 years, 9 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

NULL check GetFocusManager() before using it in ChromeWebContentsViewDelegateWin::StoreFocus(). BUG=118620 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127688

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/tab_contents/chrome_web_contents_view_delegate_win.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

That's certainly plausible. An LGTM from me is a rubberstamp; is it legitimate for the ...

8 years, 9 months ago (2012-03-20 03:18:14 UTC) #2

jam

8 years, 9 months ago (2012-03-20 15:23:12 UTC) #3

On 2012/03/20 03:18:14, Avi wrote:
> That's certainly plausible. An LGTM from me is a rubberstamp; is it legitimate
> for the focus manager to be null?

yep it is. I tried to be conservative when adding NULL checks because I didn't
want to add unnecessary ones. Looks like this one is though from the crash
report.

Expand Messages | Collapse Messages