Issue 9733003: Adjust window timings to match Cole's video.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9733003: Adjust window timings to match Cole's video. (Closed)

Created:
8 years, 9 months ago by Ben Goodger (Google)

Modified:
8 years, 9 months ago

Reviewers:
sadrul

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Adjust window timings to match Cole's video. http://crbug.com/118653 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127530

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -19 lines)			Patch
A	ash/animation_timings.h	View	1 chunk	+23 lines, -0 lines	0 comments	Download
M	ash/ash.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/wm/window_animations.cc	View	9 chunks	+24 lines, -19 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

8 years, 9 months ago (2012-03-19 18:22:18 UTC) #3

I'm giving sky a rest this morning :-)

-Ben

On Mon, Mar 19, 2012 at 11:18 AM, <sadrul@chromium.org> wrote:

> LGTM
>
> (probably sent to the wrong s*? :) )
>
>
http://codereview.chromium.**org/9733003/<http://codereview.chromium.org/9733...
>

Expand Messages | Collapse Messages