lib/dom/templates/html/impl/impl_DocumentFragment.darttemplate - Issue 9732019: dart:html perf optimization based on runing Dromaeo benchmarks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/dom/templates/html/impl/impl_DocumentFragment.darttemplate

Issue 9732019: dart:html perf optimization based on runing Dromaeo benchmarks (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Ready for review Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« lib/dom/templates/html/impl/impl_Document.darttemplate ('K') | « lib/dom/templates/html/impl/impl_Document.darttemplate ('k') | lib/dom/templates/html/impl/impl_Element.darttemplate » ('j') | lib/dom/templates/html/impl/impl_Node.darttemplate » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/dom/templates/html/impl/impl_DocumentFragment.darttemplate

diff --git a/lib/dom/templates/html/impl/impl_DocumentFragment.darttemplate b/lib/dom/templates/html/impl/impl_DocumentFragment.darttemplate

index 92c1df03f5bbd43fb098a516043275496bae8345..00639971d59be0d11866b1fbe96ca7db6d56206f 100644

--- a/lib/dom/templates/html/impl/impl_DocumentFragment.darttemplate

+++ b/lib/dom/templates/html/impl/impl_DocumentFragment.darttemplate

@@ -146,7 +146,7 @@ class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {

}

ElementList queryAll(String selectors) =>

- new _FrozenElementList._wrap(_querySelectorAll(selectors));

+ new _FrozenElementList._wrap($dom_querySelectorAll(selectors));

String get innerHTML() {

final e = new Element.tag("div");

@@ -215,8 +215,8 @@ class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {

String get tagName() => "";

String get webkitdropzone() => "";

String get webkitRegionOverflow() => "";

- Element get firstElementChild() => elements.first();

- Element get lastElementChild() => elements.last();

+ Element get $dom_firstElementChild() => elements.first();

+ Element get $dom_lastElementChild() => elements.last();

Element get nextElementSibling() => null;

Element get previousElementSibling() => null;

Element get offsetParent() => null;