Issue 9727011: Roll libjingle to r126.

Issue 9727011: Roll libjingle to r126. (Closed)

Created:
8 years, 9 months ago by Ronghua Wu (Left Chromium)

Modified:
8 years, 9 months ago

Reviewers:
Sergey Ulanov, wjia(left Chromium)

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, jam, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, joi+watch-content_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org, Henrik Grunell, perkj_chrome, Mallinath (Gone from Chromium), juberti, Niklas Enbom, tommyw

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Roll libjingle to r126. - Implemented ROAP on top of JSEP. - Added a new signal after PortAllocatorSesison discoves all candidates for the channel. TEST=try bots and apprtc.appspot.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127702

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -10 lines)			Patch
M	DEPS	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/media/mock_peer_connection_impl.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/media/mock_peer_connection_impl.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/renderer/p2p/p2p_transport_impl.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/renderer/p2p/p2p_transport_impl.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	remoting/protocol/libjingle_transport_factory.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	third_party/libjingle/README.chromium	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

lgtm with two nits. http://codereview.chromium.org/9727011/diff/3001/content/renderer/p2p/p2p_transport_impl.cc File content/renderer/p2p/p2p_transport_impl.cc (right): http://codereview.chromium.org/9727011/diff/3001/content/renderer/p2p/p2p_transport_impl.cc#newcode129 content/renderer/p2p/p2p_transport_impl.cc:129: cricket::TransportChannelImpl* /*channel*/) { no need ...

8 years, 9 months ago (2012-03-19 23:44:08 UTC) #2

Ronghua Wu (Left Chromium)

+wjia Two more changes in content/renderer/media.

8 years, 9 months ago (2012-03-20 15:12:57 UTC) #4

Ronghua Wu (Left Chromium)

http://codereview.chromium.org/9727011/diff/3001/content/renderer/p2p/p2p_transport_impl.cc File content/renderer/p2p/p2p_transport_impl.cc (right): http://codereview.chromium.org/9727011/diff/3001/content/renderer/p2p/p2p_transport_impl.cc#newcode129 content/renderer/p2p/p2p_transport_impl.cc:129: cricket::TransportChannelImpl* /*channel*/) { On 2012/03/19 23:44:08, sergeyu wrote: > ...

8 years, 9 months ago (2012-03-20 15:19:31 UTC) #5

lgtm for media/.

Expand Messages | Collapse Messages