Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: content/browser/renderer_host/resource_request_info_impl.cc

Issue 9726025: Fix bug where we'd allow chrome-extension URLs to be loaded in incognito mode (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/resource_request_info_impl.cc
diff --git a/content/browser/renderer_host/resource_request_info_impl.cc b/content/browser/renderer_host/resource_request_info_impl.cc
index 77d50119e30f48f913cd6d00f585830498c65256..a192cbd79356edf825b977a9c6bc7a410d48a212 100644
--- a/content/browser/renderer_host/resource_request_info_impl.cc
+++ b/content/browser/renderer_host/resource_request_info_impl.cc
@@ -26,6 +26,7 @@ const ResourceRequestInfo* ResourceRequestInfo::ForRequest(
// static
void ResourceRequestInfo::AllocateForTesting(
net::URLRequest* request,
+ ResourceType::Type resource_type,
ResourceContext* context) {
ResourceRequestInfoImpl* info =
new ResourceRequestInfoImpl(
@@ -35,11 +36,11 @@ void ResourceRequestInfo::AllocateForTesting(
MSG_ROUTING_NONE, // route_id
0, // origin_pid
0, // request_id
- true, // is_main_frame
+ resource_type == ResourceType::MAIN_FRAME, // is_main_frame
0, // frame_id
false, // parent_is_main_frame
0, // parent_frame_id
- ResourceType::MAIN_FRAME, // resource_type
+ resource_type, // resource_type
PAGE_TRANSITION_LINK, // transition_type
0, // upload_size
false, // is_download

Powered by Google App Engine
This is Rietveld 408576698