Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 9726014: Make sure to add rescheduled message when we have unprocessed commands and there's no error. (Closed)

Created:
8 years, 9 months ago by jbauman
Modified:
8 years, 9 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Make sure to add rescheduled message when we have unprocessed commands and there's no error. Doing this only when the stub is unscheduled causes dropped commands (and hangs) when it's rescheduled due to a timeout. BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127835

Patch Set 1 #

Total comments: 1

Patch Set 2 : change indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M content/common/gpu/gpu_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jbauman
8 years, 9 months ago (2012-03-19 21:56:48 UTC) #1
apatrick_chromium
lgtm https://chromiumcodereview.appspot.com/9726014/diff/1/content/common/gpu/gpu_command_buffer_stub.cc File content/common/gpu/gpu_command_buffer_stub.cc (right): https://chromiumcodereview.appspot.com/9726014/diff/1/content/common/gpu/gpu_command_buffer_stub.cc#newcode164 content/common/gpu/gpu_command_buffer_stub.cc:164: !gpu::error::IsError(state.error); nit: indentation
8 years, 9 months ago (2012-03-20 17:30:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/9726014/5001
8 years, 9 months ago (2012-03-20 21:06:05 UTC) #3
commit-bot: I haz the power
Try job failure for 9726014-5001 (retry) on mac_rel for step "unit_tests" (clobber build). It's a ...
8 years, 9 months ago (2012-03-20 22:18:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/9726014/5001
8 years, 9 months ago (2012-03-20 22:27:54 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-20 23:04:38 UTC) #6
Try job failure for 9726014-5001 (retry) on linux_rel for step "check_deps".
It's a second try, previously, steps "base_unittests, check_deps, net_unittests,
remoting_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698