Chromium Code Reviews| Index: runtime/vm/code_generator_x64.cc |
| =================================================================== |
| --- runtime/vm/code_generator_x64.cc (revision 5658) |
| +++ runtime/vm/code_generator_x64.cc (working copy) |
| @@ -2088,6 +2088,8 @@ |
| interpolate_arg, |
| kNoArgumentNames); |
| if (concatenated.IsUnhandledException()) { |
| + // TODO(hausner): Shouldn't we generate a throw? |
| + // Then remove unused CodeGenerator::ErrorMsg(). |
| ErrorMsg(node->token_index(), |
| "Exception thrown in CodeGenerator::VisitStringConcatNode"); |
| } |
| @@ -2452,10 +2454,7 @@ |
| const String& getter_name = String::Handle(Field::GetterName(field_name)); |
| const Function& function = |
| Function::ZoneHandle(field_class.LookupStaticFunction(getter_name)); |
| - if (function.IsNull()) { |
| - ErrorMsg(token_index, "Static getter does not exist: %s", |
| - getter_name.ToCString()); |
| - } |
| + ASSERT(!function.IsNull()); |
|
srdjan
2012/03/19 22:03:53
Ditto
regis
2012/03/19 22:54:28
Ditto.
|
| __ LoadObject(RBX, function); |
| const int kNumberOfArguments = 0; |
| const Array& kNoArgumentNames = Array::Handle(); |
| @@ -2486,6 +2485,7 @@ |
| const String& setter_name = String::Handle(Field::SetterName(field_name)); |
| const Function& function = |
| Function::ZoneHandle(field_class.LookupStaticFunction(setter_name)); |
| + ASSERT(!function.IsNull()); |
|
srdjan
2012/03/19 22:03:53
Ditto
regis
2012/03/19 22:54:28
This case is definitely checked by the parser and
|
| __ LoadObject(RBX, function); |
| const int kNumberOfArguments = 1; // value. |
| const Array& kNoArgumentNames = Array::Handle(); |