Resolve type Dynamic and implement black listing.

dart/frog/leg/compiler.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class WorkItem {
   final Element element;
   TreeElements resolutionTree;
   Function run;
   Map<int, BailoutInfo> bailouts = null;
   bool allowSpeculativeOptimization = true;
@@ skipping 37 matching lines @@
 
   CompilerTask measuredTask;
   Element _currentElement;
   LibraryElement coreLibrary;
   LibraryElement coreImplLibrary;
   LibraryElement isolateLibrary;
   LibraryElement jsHelperLibrary;
   LibraryElement mainApp;
   ClassElement objectClass;
   ClassElement closureClass;
+  ClassElement dynamicClass;
+  ClassElement boolClass;
+  ClassElement numClass;
+  ClassElement intClass;
+  ClassElement doubleClass;
+  ClassElement stringClass;
+  ClassElement functionClass;
 
   Element get currentElement() => _currentElement;
   withCurrentElement(Element element, f()) {
     Element old = currentElement;
     _currentElement = element;
     try {
       return f();
     } finally {
       _currentElement = old;
     }
@@ skipping 11 matching lines @@
   SsaCodeGeneratorTask generator;
   CodeEmitterTask emitter;
   ConstantHandler constantHandler;
   EnqueueTask enqueuer;
 
   static final SourceString MAIN = const SourceString('main');
   static final SourceString NO_SUCH_METHOD = const SourceString('noSuchMethod');
   static final SourceString NO_SUCH_METHOD_EXCEPTION =
       const SourceString('NoSuchMethodException');
   static final SourceString OBJECT = const SourceString('Object');
+  static final SourceString DYNAMIC = const SourceString('Dynamic');

[ahe, 2012/03/19 10:51:57]

I think these constants are superfluous. I'll try to get rid of most of them.

[ahe, 2012/03/19 15:31:09]

Done.

   static final SourceString START_ROOT_ISOLATE =
       const SourceString('startRootIsolate');
   static final SourceString CLOSURE = const SourceString('Closure');
   bool enabledNoSuchMethod = false;
 
   Compiler.withCurrentDirectory(String this.currentDirectory,
                                 [this.tracer = const Tracer()])
       : types = new Types(),
         universe = new Universe(),
         worklist = new Queue<WorkItem>() {
@@ skipping 81 matching lines @@
 
   void enableIsolateSupport(LibraryElement element) {
     isolateLibrary = element;
     addToWorkList(element.find(START_ROOT_ISOLATE)); 
   }
 
   void onLibraryLoaded(LibraryElement library, Uri uri) {
     if (uri.toString() == 'dart:isolate') {
       enableIsolateSupport(library);
     }
+    if (dynamicClass !== null) {

[ahe, 2012/03/19 10:51:57]

dynamicClass is null while loading the built-in libraries. I'll add a TODO.

[ahe, 2012/03/19 15:31:09]

Done.

+      withCurrentElement(library, () {
+        library.define(dynamicClass, this);
+      });
+    }
   }
 
   abstract LibraryElement scanBuiltinLibrary(String filename);
 
   void scanBuiltinLibraries() {
     coreImplLibrary = scanBuiltinLibrary('coreimpl.dart');
     jsHelperLibrary = scanBuiltinLibrary('js_helper.dart');
     coreLibrary = scanBuiltinLibrary('core.dart');
     objectClass = coreLibrary.find(OBJECT);
+    boolClass = coreLibrary.find(const SourceString('bool'));
+    numClass = coreLibrary.find(const SourceString('num'));
+    intClass = coreLibrary.find(const SourceString('int'));
+    doubleClass = coreLibrary.find(const SourceString('double'));
+    stringClass = coreLibrary.find(const SourceString('String'));
+    functionClass = coreLibrary.find(const SourceString('Function'));
+
     closureClass = jsHelperLibrary.find(CLOSURE);
+    dynamicClass = new ClassElement(DYNAMIC, coreLibrary);

[ngeoffray, 2012/03/19 11:48:01]

Wy don't we have a 'class Dynamic' in the core library? And change the resolver
to set its super to null ?

[ahe, 2012/03/19 15:31:09]

Done.

+    dynamicClass.isResolved = true;
     // Since coreLibrary import the libraries "coreimpl", and
     // "js_helper", coreLibrary is null when they are being built. So
     // we add the implicit import of coreLibrary now. This can be
     // cleaned up when we have proper support for "dart:core" and
     // don't need to access it through the field "coreLibrary".
     // TODO(ahe): Clean this up as described above.
     scanner.importLibrary(coreImplLibrary, coreLibrary, null);
     scanner.importLibrary(jsHelperLibrary, coreLibrary, null);
     addForeignFunctions(jsHelperLibrary);
 
@@ skipping 264 matching lines @@
   }
 }
 
 class SourceSpan {
   final Uri uri;
   final int begin;
   final int end;
 
   const SourceSpan(this.uri, this.begin, this.end);
 }