Issue 9724022: Add API call that identifies strings that are guaranteed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9724022: Add API call that identifies strings that are guaranteed (Closed)

Created:
8 years, 9 months ago by Erik Corry

Modified:
8 years, 9 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Add API call that identifies strings that are guaranteed only to contain ASCII characters. Committed: https://code.google.com/p/v8/source/detail?r=11079

Patch Set 1 #

Total comments: 4

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -0 lines)			Patch
M	include/v8.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+9 lines, -0 lines	2 comments	Download
M	test/cctest/test-api.cc	View	2 chunks	+5 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

fschneider

lgtm https://chromiumcodereview.appspot.com/9724022/diff/1/src/api.cc File src/api.cc (right): https://chromiumcodereview.appspot.com/9724022/diff/1/src/api.cc#newcode3700 src/api.cc:3700: return 0; you mean "return false"? https://chromiumcodereview.appspot.com/9724022/diff/1/test/cctest/test-api.cc File ...

8 years, 9 months ago (2012-03-19 08:46:31 UTC) #2

Erik Corry

8 years, 9 months ago (2012-03-19 09:51:02 UTC) #3

https://chromiumcodereview.appspot.com/9724022/diff/1/src/api.cc
File src/api.cc (right):

https://chromiumcodereview.appspot.com/9724022/diff/1/src/api.cc#newcode3700
src/api.cc:3700: return 0;
On 2012/03/19 08:46:31, fschneider wrote:
> you mean "return false"?

Done.

https://chromiumcodereview.appspot.com/9724022/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://chromiumcodereview.appspot.com/9724022/diff/1/test/cctest/test-api.cc...
test/cctest/test-api.cc:5774: string->MayContainNonAscii());
On 2012/03/19 08:46:31, fschneider wrote:
> Fix indentation here.

Done.

Expand Messages | Collapse Messages