content/browser/frame_host/frame_tree_node.h - Issue 972313002: Make <webview> use out-of-process iframe architecture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/frame_tree_node.h

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome

Patch Set: address comments from nasko@ + git cl format Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/browser_plugin/browser_plugin_guest.cc ('K') | « content/browser/frame_host/cross_process_frame_connector.cc ('k') | content/browser/frame_host/render_frame_host_manager.h » ('j') | content/browser/frame_host/render_frame_host_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/frame_tree_node.h

diff --git a/content/browser/frame_host/frame_tree_node.h b/content/browser/frame_host/frame_tree_node.h

index 2cdf527eaa74c0dff125a04bbc7ef1216d273a03..59db73b873bd9a5fee9033f93a371669b88a9930 100644

--- a/content/browser/frame_host/frame_tree_node.h

+++ b/content/browser/frame_host/frame_tree_node.h

@@ -43,6 +43,8 @@ class CONTENT_EXPORT FrameTreeNode {

// regardless of which FrameTree it is in.

static FrameTreeNode* GloballyFindByID(int frame_tree_node_id);

+ static const int kFrameTreeNodeInvalidID = -1;

Charlie Reis 2015/06/18 00:13:18 nit: This should go above static methods.

lazyboy 2015/06/18 22:45:12 Done.

FrameTreeNode(FrameTree* frame_tree,

Navigator* navigator,

RenderFrameHostDelegate* render_frame_delegate,