Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.h

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome
Patch Set: Rebase after swapped out changes major rework with RFP Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_view_guest.h
diff --git a/extensions/browser/guest_view/web_view/web_view_guest.h b/extensions/browser/guest_view/web_view/web_view_guest.h
index 517c1db5095b46150adc5cabcdfd314e1876b903..843b4a82edfd94be68677bf4f110d70c709bff92 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest.h
+++ b/extensions/browser/guest_view/web_view/web_view_guest.h
@@ -23,6 +23,10 @@ namespace blink {
struct WebFindOptions;
} // nanespace blink
+namespace content {
+struct GlobalRequestID;
+} // namespace content
+
namespace extensions {
class WebViewInternalFindFunction;
@@ -316,10 +320,13 @@ class WebViewGuest : public guest_view::GuestView<WebViewGuest>,
// Loads the |url| provided. |force_navigation| indicates whether to reload
// the content if the provided |url| matches the current page of the guest.
- void LoadURLWithParams(const GURL& url,
- const content::Referrer& referrer,
- ui::PageTransition transition_type,
- bool force_navigation);
+ // TODO(lazyboy): Use OpenURLParams as parameter.?
Fady Samuel 2015/06/11 22:27:21 The WebViewGuest changes seem like something you c
+ void LoadURLWithParams(
+ const GURL& url,
+ const content::Referrer& referrer,
+ ui::PageTransition transition_type,
+ const content::GlobalRequestID& transferred_global_request_id,
+ bool force_navigation);
void RequestNewWindowPermission(
WindowOpenDisposition disposition,

Powered by Google App Engine
This is Rietveld 408576698