content/browser/frame_host/cross_process_frame_connector.cc - Issue 972313002: Make <webview> use out-of-process iframe architecture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/cross_process_frame_connector.cc

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome

Patch Set: address comments from creis@ Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | content/browser/frame_host/render_frame_host_manager.h » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/cross_process_frame_connector.cc

diff --git a/content/browser/frame_host/cross_process_frame_connector.cc b/content/browser/frame_host/cross_process_frame_connector.cc

index b116792d18566bacf2b6b61e9a70a7eb9c6ea4b6..799f9f330c65049f400a44b49bbab7d817513711 100644

--- a/content/browser/frame_host/cross_process_frame_connector.cc

+++ b/content/browser/frame_host/cross_process_frame_connector.cc

@@ -6,6 +6,8 @@

#include "cc/surfaces/surface.h"

#include "cc/surfaces/surface_manager.h"

+#include "content/browser/frame_host/frame_tree_node.h"

+#include "content/browser/frame_host/render_frame_host_manager.h"

#include "content/browser/frame_host/render_frame_proxy_host.h"

#include "content/browser/frame_host/render_widget_host_view_child_frame.h"

#include "content/browser/renderer_host/render_view_host_impl.h"

@@ -154,8 +156,12 @@ void CrossProcessFrameConnector::OnForwardInputEvent(

RenderWidgetHostImpl* child_widget =

RenderWidgetHostImpl::From(view_->GetRenderWidgetHost());

+ RenderFrameHostManager* manager =

+ frame_proxy_in_parent_renderer_->frame_tree_node()->render_manager();

RenderWidgetHostImpl* parent_widget =

- frame_proxy_in_parent_renderer_->GetRenderViewHost();

+ manager->ForInnerDelegate()

+ ? manager->GetOuterRenderWidgetHostForKeyboardInput()

+ : frame_proxy_in_parent_renderer_->GetRenderViewHost();

if (blink::WebInputEvent::isKeyboardEventType(event->type)) {

if (!parent_widget->GetLastKeyboardEvent())