extensions/renderer/guest_view/extensions_guest_view_container.h - Issue 972313002: Make <webview> use out-of-process iframe architecture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/guest_view/extensions_guest_view_container.h

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome

Patch Set: address all comments from Nasko and Charlie, minus is_loading Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/guest_view/extensions_guest_view_message_filter.cc ('K') | « extensions/renderer/dispatcher.cc ('k') | extensions/renderer/guest_view/extensions_guest_view_container.cc » ('j') | extensions/renderer/guest_view/extensions_guest_view_container.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/guest_view/extensions_guest_view_container.h

diff --git a/extensions/renderer/guest_view/extensions_guest_view_container.h b/extensions/renderer/guest_view/extensions_guest_view_container.h

index 0a29daf22c4210008a7e37abd20d48bb267f0100..5b5859a588754882f6351329cca3f3bf66e4c383 100644

--- a/extensions/renderer/guest_view/extensions_guest_view_container.h

+++ b/extensions/renderer/guest_view/extensions_guest_view_container.h

@@ -26,6 +26,9 @@ class ExtensionsGuestViewContainer : public GuestViewContainer {

void RegisterElementResizeCallback(v8::Local<v8::Function> callback,

v8::Isolate* isolate);

+ // GuestViewContainer overrides.

+ bool OnMessage(const IPC::Message& message) override;

// BrowserPluginDelegate implementation.

void DidResizeElement(const gfx::Size& old_size,

const gfx::Size& new_size) override;