Make <webview> use out-of-process iframe architecture.

extensions/renderer/resources/guest_view/guest_view_container.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This module implements the shared functionality for different guestview
 // containers, such as web_view, app_view, etc.
 
 var DocumentNatives = requireNative('document_natives');
 var GuestView = require('guestView').GuestView;
 var GuestViewInternalNatives = requireNative('guest_view_internal');
 var IdGenerator = requireNative('id_generator');
 
 function GuestViewContainer(element, viewType) {
   privates(element).internal = this;
   this.attributes = {};
   this.element = element;
   this.elementAttached = false;
   this.viewInstanceId = IdGenerator.GetNextId();
   this.viewType = viewType;
 
   this.setupGuestProperty();
   this.guest = new GuestView(viewType);
   this.setupAttributes();
 
   privates(this).browserPluginElement = this.createBrowserPluginElement();
+  this.guest.setBrowserPluginElement(privates(this).browserPluginElement);

[Fady Samuel, 2015/05/26 16:42:15]

Why is this necessary? Also, guests can change their container.

   this.setupFocusPropagation();
   var shadowRoot = this.element.createShadowRoot();
   shadowRoot.appendChild(privates(this).browserPluginElement);
 }
 
 // Forward public API methods from |proto| to their internal implementations.
 GuestViewContainer.forwardApiMethods = function(proto, apiMethods) {
   var createProtoHandler = function(m) {
     return function(var_args) {
       var internal = privates(this).internal;
@@ skipping 48 matching lines @@
 
 GuestViewContainer.prototype.createBrowserPluginElement = function() {
   // We create BrowserPlugin as a custom element in order to observe changes
   // to attributes synchronously.
   var browserPluginElement =
       new GuestViewContainer[this.viewType + 'BrowserPlugin']();
   privates(browserPluginElement).internal = this;
   return browserPluginElement;
 };
 
+GuestViewContainer.prototype.getBrowserPluginElement = function() {
+  return privates(this).browserPluginElement;
+};
+
 GuestViewContainer.prototype.setupFocusPropagation = function() {
   if (!this.element.hasAttribute('tabIndex')) {
     // GuestViewContainer needs a tabIndex in order to be focusable.
     // TODO(fsamuel): It would be nice to avoid exposing a tabIndex attribute
     // to allow GuestViewContainer to be focusable.
     // See http://crbug.com/231664.
     this.element.setAttribute('tabIndex', -1);
   }
   this.element.addEventListener('focus', function(e) {
     // Focus the BrowserPlugin when the GuestViewContainer takes focus.
     privates(this).browserPluginElement.focus();
   }.bind(this));
   this.element.addEventListener('blur', function(e) {
     // Blur the BrowserPlugin when the GuestViewContainer loses focus.
     privates(this).browserPluginElement.blur();
   }.bind(this));
 };
 
 GuestViewContainer.prototype.attachWindow = function() {
   if (!this.internalInstanceId) {
     return true;
   }
 
   this.guest.attach(this.internalInstanceId,
                     this.viewInstanceId,
                     this.buildParams());
   return true;
 };
 
+GuestViewContainer.prototype.onInternalInstanceID = function(
+    internalInstanceId) {
+  window.console.log('onInternalInstanceID: ' + internalInstanceId);
+  this.internalInstanceId = internalInstanceId;
+
+  // Track when the element resizes using the element resize callback.
+  GuestViewInternalNatives.RegisterElementResizeCallback(
+      this.internalInstanceId, this.onElementResize.bind(this));
+
+  window.console.log('this.guest.getId() = ' +
+      this.guest.getId());
+  if (!this.guest.getId()) {
+    return;
+  }
+  this.guest.attach(this.internalInstanceId,
+                    this.viewInstanceId,
+                    this.buildParams());
+};
+
 GuestViewContainer.prototype.handleBrowserPluginAttributeMutation =
     function(name, oldValue, newValue) {
   if (name == 'internalinstanceid' && !oldValue && !!newValue) {
     privates(this).browserPluginElement.removeAttribute('internalinstanceid');
-    this.internalInstanceId = parseInt(newValue);
-
-    // Track when the element resizes using the element resize callback.
-    GuestViewInternalNatives.RegisterElementResizeCallback(
-        this.internalInstanceId, this.onElementResize.bind(this));
-
-    if (!this.guest.getId()) {
-      return;
-    }
-    this.guest.attach(this.internalInstanceId,
-                      this.viewInstanceId,
-                      this.buildParams());
+    this.onInternalInstanceID(parseInt(newValue));
   }
 };
 
 GuestViewContainer.prototype.onElementResize = function(oldWidth, oldHeight,
                                                         newWidth, newHeight) {
   // Dispatch the 'resize' event.
   var resizeEvent = new Event('resize', { bubbles: true });
   resizeEvent.oldWidth = oldWidth;
   resizeEvent.oldHeight = oldHeight;
   resizeEvent.newWidth = newWidth;
@@ skipping 27 matching lines @@
 }
 
 // Implemented by the specific view type, if needed.
 GuestViewContainer.prototype.buildContainerParams = function() { return {}; };
 GuestViewContainer.prototype.onElementAttached = function() {};
 GuestViewContainer.prototype.onElementDetached = function() {};
 GuestViewContainer.prototype.setupAttributes = function() {};
 
 // Registers the browser plugin <object> custom element. |viewType| is the
 // name of the specific guestview container (e.g. 'webview').
 function registerBrowserPluginElement(viewType) {

[Fady Samuel, 2015/05/26 16:42:15]

Is this at all necessary in sitePerProcess?

[lazyboy, 2015/05/29 00:02:24]

This function would register the custom element inside the shadow
to be an iframe type. So we still need it.

-  var proto = $Object.create(HTMLElement.prototype);
+  var isSitePerProcess = GuestViewInternalNatives.IsSitePerProcess();
+  var proto = $Object.create(isSitePerProcess ? HTMLIFrameElement.prototype
+                                              : HTMLElement.prototype);
+
+  window.console.log('isSitePerProcess: ' + isSitePerProcess);
 
   proto.createdCallback = function() {
-    this.setAttribute('type', 'application/browser-plugin');
-    this.setAttribute('id', 'browser-plugin-' + IdGenerator.GetNextId());
+    if (!isSitePerProcess) {
+      this.setAttribute('type', 'application/browser-plugin');
+      this.setAttribute('id', 'browser-plugin-' + IdGenerator.GetNextId());
+    }
     this.style.width = '100%';
     this.style.height = '100%';
   };
 
   proto.attachedCallback = function() {
     // Load the plugin immediately.
     var unused = this.nonExistentAttribute;
   };
 
-  proto.attributeChangedCallback = function(name, oldValue, newValue) {
-    var internal = privates(this).internal;
-    if (!internal) {
-      return;
-    }
-    internal.handleBrowserPluginAttributeMutation(name, oldValue, newValue);
-  };
+  if (!isSitePerProcess) {
+    proto.attributeChangedCallback = function(name, oldValue, newValue) {
+      var internal = privates(this).internal;
+      if (!internal) {
+        return;
+      }
+      internal.handleBrowserPluginAttributeMutation(name, oldValue, newValue);
+    };
+  }
 
+  var options = {prototype: proto};
+  options.extends = isSitePerProcess ? 'iframe' : 'object';
   GuestViewContainer[viewType + 'BrowserPlugin'] =
-      DocumentNatives.RegisterElement(viewType + 'browserplugin',
-                                      {extends: 'object', prototype: proto});
+      DocumentNatives.RegisterElement(viewType + 'browserplugin', options);
 
   delete proto.createdCallback;
   delete proto.attachedCallback;
   delete proto.detachedCallback;
   delete proto.attributeChangedCallback;
 };
 
 // Registers the guestview container as a custom element.
 // |guestViewContainerType| is the type of guestview container
 // (e.g.WebViewImpl).
@@ skipping 48 matching lines @@
   // Delete the callbacks so developers cannot call them and produce unexpected
   // behavior.
   delete proto.createdCallback;
   delete proto.attachedCallback;
   delete proto.detachedCallback;
   delete proto.attributeChangedCallback;
 }
 
 // Exports.
 exports.GuestViewContainer = GuestViewContainer;