Make <webview> use out-of-process iframe architecture.

extensions/renderer/resources/guest_view/web_view.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This module implements WebView (<webview>) as a custom element that wraps a
 // BrowserPlugin object element. The object element is hidden within
 // the shadow DOM of the WebView element.
 
 var DocumentNatives = requireNative('document_natives');
 var GuestView = require('guestView').GuestView;
 var GuestViewContainer = require('guestViewContainer').GuestViewContainer;
 var WebViewConstants = require('webViewConstants').WebViewConstants;
 var WebViewEvents = require('webViewEvents').WebViewEvents;
 var WebViewInternal = require('webViewInternal').WebViewInternal;
 
+var IdGenerator = requireNative('id_generator');
+var GuestViewInternalNatives = requireNative('guest_view_internal');
+
+var LOG = function(msg) { window.console.log(msg); };
+
 // Represents the internal state of <webview>.
 function WebViewImpl(webviewElement) {
   GuestViewContainer.call(this, webviewElement, 'webview');
 
   this.setupWebViewAttributes();
   this.setupElementProperties();
 
   // on* Event handlers.
   this.on = {};
   new WebViewEvents(this, this.viewInstanceId);
@@ skipping 30 matching lines @@
           createDefaultApiMethod(apiMethods[i]);
     }
   }
 
   // Forward proto.foo* method calls to WebViewImpl.foo*.
   GuestViewContainer.forwardApiMethods(proto, apiMethods);
 };
 
 // Initiates navigation once the <webview> element is attached to the DOM.
 WebViewImpl.prototype.onElementAttached = function() {
+  // FIXME: Not sure about this one.
   this.attributes[WebViewConstants.ATTRIBUTE_SRC].parse();

[Fady Samuel, 2015/03/04 20:44:48]

This code is old. What's the problem here?

 };
 
 // Resets some state upon detaching <webview> element from the DOM.
 WebViewImpl.prototype.onElementDetached = function() {
   this.guest.destroy();
   for (var i in this.attributes) {
     this.attributes[i].reset();
   }
 };
 
@@ skipping 112 matching lines @@
 
 // Updates state upon loadcommit.
 WebViewImpl.prototype.onLoadCommit = function(
     baseUrlForDataUrl, currentEntryIndex, entryCount,
     processId, url, isTopLevel) {
   this.baseUrlForDataUrl = baseUrlForDataUrl;
   this.currentEntryIndex = currentEntryIndex;
   this.entryCount = entryCount;
   this.processId = processId;
   var oldValue = this.attributes[WebViewConstants.ATTRIBUTE_SRC].getValue();
+  LOG('WebViewImpl.onLoadCommit, oldValue = ' + oldValue +
+      ',  newValue = ' + newValue);
   var newValue = url;
   if (isTopLevel && (oldValue != newValue)) {
     // Touching the src attribute triggers a navigation. To avoid
     // triggering a page reload on every guest-initiated navigation,
     // we do not handle this mutation.
     this.attributes[WebViewConstants.ATTRIBUTE_SRC].setValueIgnoreMutation(
         newValue);
   }
 };
 
@@ skipping 14 matching lines @@
   // If |opt_guestInstanceId| was provided, then a different existing guest is
   // being attached to this webview, and the current one will get destroyed.
   if (opt_guestInstanceId) {
     if (this.guest.getId() == opt_guestInstanceId) {
       return true;
     }
     this.guest.destroy();
     this.guest = new GuestView('webview', opt_guestInstanceId);
   }
 
+  /*
+  if (!this.internalInstanceId) {
+    return true;
+  }
+  */
+
+  LOG('Guest will start attach');
+  var generatedId = IdGenerator.GetNextId();
+  this.internalInstanceId = generatedId;
+
+  LOG('this.guest.getId() = ' + this.guest.getId());
+  var ret = GuestViewInternalNatives.AttachIframeGuest(
+      this.internalInstanceId, this.guest.getId(),
+      this.getBrowserPluginElement(), function(contentWindow) {
+        LOG(contentWindow);
+        this.guest.setContentWindow(contentWindow);
+      }.bind(this));
+
+  LOG('guestViewInternalNatives.AttachIframeGuest status: ' + ret);
+
+  window.setTimeout(function() {
+    LOG('<webview>: navigate');
+    var src =
+        this.attributes[WebViewConstants.ATTRIBUTE_SRC].getValue();
+    WebViewInternal.navigate(
+        this.guest.getId(), src);

[Fady Samuel, 2015/03/04 20:44:48]

This totally breaks the new window API.

+  }.bind(this), 0);
+
+  return true;
+  // Note: Following stuff IGNORED.
   return GuestViewContainer.prototype.attachWindow.call(this);
 };
 
 // Shared implementation of executeScript() and insertCSS().
 WebViewImpl.prototype.executeCode = function(func, args) {
   if (!this.guest.getId()) {
     window.console.error(WebViewConstants.ERROR_MSG_CANNOT_INJECT_SCRIPT);
     return false;
   }
 
   var webviewSrc = this.attributes[WebViewConstants.ATTRIBUTE_SRC].getValue();
   if (this.baseUrlForDataUrl != '') {
     webviewSrc = this.baseUrlForDataUrl;
   }
+  LOG('webviewSrc: ' + webviewSrc);
 
   args = $Array.concat([this.guest.getId(), webviewSrc],
                        $Array.slice(args));
   $Function.apply(func, null, args);
   return true;
 }
 
 // Implemented when the ChromeWebView API is available.
 WebViewImpl.prototype.maybeGetChromeWebViewEvents = function() {};
 
 // Implemented when the experimental WebView API is available.
 WebViewImpl.maybeGetExperimentalApiMethods = function() { return []; };
 WebViewImpl.prototype.setupExperimentalContextMenus = function() {};
 WebViewImpl.prototype.maybeSetupExperimentalChromeWebViewEvents =
   function(request) {
     return request;
 };
 
 GuestViewContainer.registerElement(WebViewImpl);
 
 // Exports.
 exports.WebViewImpl = WebViewImpl;