Make <webview> use out-of-process iframe architecture.

extensions/browser/guest_view/web_view/web_view_guest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/guest_view/web_view/web_view_guest.h"
 
 #include "base/message_loop/message_loop.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/public/browser/browser_context.h"
@@ skipping 276 matching lines @@
                               content::Source<WebContents>(web_contents()));
 
   if (web_view_guest_delegate_)
     web_view_guest_delegate_->OnDidInitialize();
   AttachWebViewHelpers(web_contents());
 
   rules_registry_id_ = GetOrGenerateRulesRegistryID(
       owner_web_contents()->GetRenderProcessHost()->GetID(),
       view_instance_id());
 
-  // We must install the mapping from guests to WebViews prior to resuming
-  // suspended resource loads so that the WebRequest API will catch resource
-  // requests.
-  PushWebViewStateToIOThread();
+  // NOTE: Calling this prior to attachment breaks OOPIF <webview>.
+  //// We must install the mapping from guests to WebViews prior to resuming
+  //// suspended resource loads so that the WebRequest API will catch resource
+  //// requests.
+  //PushWebViewStateToIOThread();

[Fady Samuel, 2015/03/04 20:44:47]

This makes me sad.

[lazyboy, 2015/04/01 21:47:58]

These changes here are temporary, I'll fix these once content/ changes get
settled.

 
-  ApplyAttributes(create_params);
+  //ApplyAttributes(create_params);
 }
 
 void WebViewGuest::AttachWebViewHelpers(WebContents* contents) {
   if (web_view_guest_delegate_)
     web_view_guest_delegate_->OnAttachWebViewHelpers(contents);
   web_view_permission_helper_.reset(new WebViewPermissionHelper(this));
 }
 
 void WebViewGuest::DidStopLoading() {
   scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue());
@@ skipping 156 matching lines @@
 }
 
 void WebViewGuest::OnFrameNameChanged(bool is_top_level,
                                       const std::string& name) {
   if (!is_top_level)
     return;
 
   if (name_ == name)
     return;
 
-  ReportFrameNameChange(name);
+  //ReportFrameNameChange(name);

[Fady Samuel, 2015/03/04 20:44:47]

This makes me sad.

 }
 
 void WebViewGuest::CreateNewGuestWebViewWindow(
     const content::OpenURLParams& params) {
   GuestViewManager* guest_manager =
       GuestViewManager::FromBrowserContext(browser_context());
   // Set the attach params to use the same partition as the opener.
   // We pull the partition information from the site's URL, which is of the
   // form guest://site/{persist}?{partition_name}.
   const GURL& site_url = web_contents()->GetSiteInstance()->GetSiteURL();
@@ skipping 363 matching lines @@
 }
 
 void WebViewGuest::WillAttachToEmbedder() {
   rules_registry_id_ = GetOrGenerateRulesRegistryID(
       owner_web_contents()->GetRenderProcessHost()->GetID(),
       view_instance_id());
 
   // We must install the mapping from guests to WebViews prior to resuming
   // suspended resource loads so that the WebRequest API will catch resource
   // requests.
-  PushWebViewStateToIOThread();
+  //PushWebViewStateToIOThread();

[Fady Samuel, 2015/03/04 20:44:47]

This makes me sad.

 }
 
 content::JavaScriptDialogManager* WebViewGuest::GetJavaScriptDialogManager(
     WebContents* source) {
   return &javascript_dialog_helper_;
 }
 
 void WebViewGuest::NavigateGuest(const std::string& src,
                                  bool force_navigation) {
   if (src.empty())
@@ skipping 17 matching lines @@
   }
   if (!force_navigation && (src_ == url))
     return;
 
   GURL validated_url(url);
   web_contents()->GetRenderProcessHost()->FilterURL(false, &validated_url);
   // As guests do not swap processes on navigation, only navigations to
   // normal web URLs are supported.  No protocol handlers are installed for
   // other schemes (e.g., WebUI or extensions), and no permissions or bindings
   // can be granted to the guest process.
+  printf("Calling LoadURLWithParams\n");
   LoadURLWithParams(validated_url,
                     content::Referrer(),
                     ui::PAGE_TRANSITION_AUTO_TOPLEVEL,
                     web_contents());
 
   src_ = validated_url;
 }
 
 bool WebViewGuest::HandleKeyboardShortcuts(
     const content::NativeWebKeyboardEvent& event) {
@@ skipping 41 matching lines @@
 
 void WebViewGuest::ApplyAttributes(const base::DictionaryValue& params) {
   std::string name;
   if (params.GetString(webview::kAttributeName, &name)) {
     // If the guest window's name is empty, then the WebView tag's name is
     // assigned. Otherwise, the guest window's name takes precedence over the
     // WebView tag's name.
     if (name_.empty())
       SetName(name);
   }
-  if (attached())
-    ReportFrameNameChange(name_);
+  //if (attached())
+  //  ReportFrameNameChange(name_);
 
   std::string user_agent_override;
   params.GetString(webview::kParameterUserAgentOverride, &user_agent_override);
   SetUserAgentOverride(user_agent_override);
 
   bool allow_transparency = false;
   params.GetBoolean(webview::kAttributeAllowTransparency, &allow_transparency);
   // We need to set the background opaque flag after navigation to ensure that
   // there is a RenderWidgetHostView available.
   SetAllowTransparency(allow_transparency);
@@ skipping 142 matching lines @@
 }
 
 content::WebContents* WebViewGuest::OpenURLFromTab(
     content::WebContents* source,
     const content::OpenURLParams& params) {
   // If the guest wishes to navigate away prior to attachment then we save the
   // navigation to perform upon attachment. Navigation initializes a lot of
   // state that assumes an embedder exists, such as RenderWidgetHostViewGuest.
   // Navigation also resumes resource loading which we don't want to allow
   // until attachment.
+  // site-per-process
+  printf("source: [%p], web_contents(): [%p]\n", source, web_contents());

[Fady Samuel, 2015/03/04 20:44:47]

This basically breaks the new window API. Why is this necessary?

+  printf("web_contents(): [%p]\n", web_contents());
+  //CHECK(0);
+  content::NavigationController::LoadURLParams load_url_params(
+      params.url);
+  load_url_params.referrer = params.referrer;
+  load_url_params.transition_type = params.transition;
+  load_url_params.extra_headers = std::string();
+  //load_url_params.frame_tree_node_id = params.frame_tree_node_id;
+  load_url_params.transferred_global_request_id =
+      params.transferred_global_request_id;
+  source->GetController().LoadURLWithParams(load_url_params);
+  return source;
+
+  // Note: IGNORED.
   if (!attached()) {
     WebViewGuest* opener = GetOpener();
     auto it = opener->pending_new_windows_.find(this);
     if (it == opener->pending_new_windows_.end())
       return nullptr;
     const NewWindowInfo& info = it->second;
     NewWindowInfo new_window_info(params.url, info.name);
     new_window_info.changed = new_window_info.url != info.url;
     it->second = new_window_info;
     return nullptr;
@@ skipping 96 matching lines @@
       WebViewGuest::From(owner_web_contents()->GetRenderProcessHost()->GetID(),
                          new_window_instance_id);
   if (!guest)
     return;
 
   if (!allow)
     guest->Destroy();
 }
 
 }  // namespace extensions