Make <webview> use out-of-process iframe architecture.

content/browser/frame_host/render_frame_proxy_host.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_proxy_host.h"
 
 #include "base/lazy_instance.h"
 #include "content/browser/frame_host/cross_process_frame_connector.h"
 #include "content/browser/frame_host/frame_tree.h"
 #include "content/browser/frame_host/frame_tree_node.h"
@@ skipping 28 matching lines @@
       RenderFrameProxyHostID(process_id, routing_id));
   return it == frames->end() ? NULL : it->second;
 }
 
 RenderFrameProxyHost::RenderFrameProxyHost(SiteInstance* site_instance,
                                            FrameTreeNode* frame_tree_node)
     : routing_id_(site_instance->GetProcess()->GetNextRoutingID()),
       site_instance_(site_instance),
       process_(site_instance->GetProcess()),
       frame_tree_node_(frame_tree_node),
-      render_frame_proxy_created_(false) {
+      render_frame_proxy_created_(false),
+      pseudo_parent_frame_tree_node_id_(-1) {
   GetProcess()->AddRoute(routing_id_, this);
   CHECK(g_routing_id_frame_proxy_map.Get().insert(
       std::make_pair(
           RenderFrameProxyHostID(GetProcess()->GetID(), routing_id_),
           this)).second);
 
-  if (!frame_tree_node_->IsMainFrame() &&
+  bool is_proxy_to_embedder_for_guest =
+      frame_tree_node_->IsMainFrame() &&
+      frame_tree_node_->render_manager()->current_frame_host()
+          ->GetSiteInstance()->GetSiteURL().SchemeIs("chrome-guest");

[Fady Samuel, 2015/03/04 22:21:06]

This is not feasible for guests that are not isolated such as
<extensionoptions>, <extensionview>, <appview>, and MimeHandlerView.

[Charlie Reis, 2015/03/10 04:09:44]

Tangent: what does "not isolated" mean here?

+  if ((!frame_tree_node_->IsMainFrame() &&
       frame_tree_node_->parent()
               ->render_manager()
               ->current_frame_host()
-              ->GetSiteInstance() == site_instance) {
+              ->GetSiteInstance() == site_instance) ||
+      is_proxy_to_embedder_for_guest) {
     // The RenderFrameHost navigating cross-process is destroyed and a proxy for
     // it is created in the parent's process. CrossProcessFrameConnector
     // initialization only needs to happen on an initial cross-process
     // navigation, when the RenderFrameHost leaves the same process as its
     // parent. The same CrossProcessFrameConnector is used for subsequent cross-
     // process navigations, but it will be destroyed if the frame is
     // navigated back to the same SiteInstance as its parent.
     cross_process_frame_connector_.reset(new CrossProcessFrameConnector(this));
   }
 }
@@ skipping 11 matching lines @@
   GetProcess()->RemoveRoute(routing_id_);
   g_routing_id_frame_proxy_map.Get().erase(
       RenderFrameProxyHostID(GetProcess()->GetID(), routing_id_));
 }
 
 void RenderFrameProxyHost::SetChildRWHView(RenderWidgetHostView* view) {
   cross_process_frame_connector_->set_view(
       static_cast<RenderWidgetHostViewChildFrame*>(view));
 }
 
+void RenderFrameProxyHost::SetOverriddenParentFTNID(
+    int64 pseudo_parent_frame_tree_node_id) {
+  pseudo_parent_frame_tree_node_id_ =

[Charlie Reis, 2015/03/10 04:09:44]

embedder_frame_tree_node_id_

[lazyboy, 2015/04/01 21:47:57]

Obsolete now.

+      pseudo_parent_frame_tree_node_id;
+}
+
 RenderViewHostImpl* RenderFrameProxyHost::GetRenderViewHost() {

[Charlie Reis, 2015/03/10 04:09:44]

Note: We could probably just cache a pointer to the RVH in this class (passed in
via the constructor), as we do in RenderFrameHostImpl.  That might be cleaner
than tracking the embedder's FrameTreeNode ID, etc.

[lazyboy, 2015/04/01 21:47:57]

Added a TODO since we're not tracking embedder's FTN ID here anymore.

-  return frame_tree_node_->frame_tree()->GetRenderViewHost(
-      site_instance_.get());
+  FrameTree* ft = NULL;

[Charlie Reis, 2015/03/10 04:09:44]

embedder_frame_tree = nullptr;

+  if (pseudo_parent_frame_tree_node_id_ >= 0) {
+    ft = FrameTree::GloballyFindByID(
+        pseudo_parent_frame_tree_node_id_)->frame_tree();
+  } else {
+    ft = frame_tree_node_->frame_tree();
+  }
+  return ft->GetRenderViewHost(site_instance_.get());
 }
 
 void RenderFrameProxyHost::TakeFrameHostOwnership(
     scoped_ptr<RenderFrameHostImpl> render_frame_host) {
   render_frame_host_ = render_frame_host.Pass();
   render_frame_host_->set_render_frame_proxy_host(this);
 }
 
 scoped_ptr<RenderFrameHostImpl> RenderFrameProxyHost::PassFrameHostOwnership() {
   render_frame_host_->set_render_frame_proxy_host(NULL);
@@ skipping 51 matching lines @@
 void RenderFrameProxyHost::DisownOpener() {
   Send(new FrameMsg_DisownOpener(GetRoutingID()));
 }
 
 void RenderFrameProxyHost::OnOpenURL(
     const FrameHostMsg_OpenURL_Params& params) {
   frame_tree_node_->current_frame_host()->OpenURL(params, site_instance_.get());
 }
 
 }  // namespace content