Make <webview> use out-of-process iframe architecture.

content/browser/frame_host/render_frame_host_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_manager.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 43 matching lines @@
     RenderFrameHostDelegate* render_frame_delegate,
     RenderViewHostDelegate* render_view_delegate,
     RenderWidgetHostDelegate* render_widget_delegate,
     Delegate* delegate)
     : frame_tree_node_(frame_tree_node),
       delegate_(delegate),
       cross_navigation_pending_(false),
       render_frame_delegate_(render_frame_delegate),
       render_view_delegate_(render_view_delegate),
       render_widget_delegate_(render_widget_delegate),
+      pseudo_parent_frame_tree_node_id_(-1),
       interstitial_page_(nullptr),
       should_reuse_web_ui_(false),
       weak_factory_(this) {
   DCHECK(frame_tree_node_);
 }
 
 RenderFrameHostManager::~RenderFrameHostManager() {
   if (pending_render_frame_host_)
     UnsetPendingRenderFrameHost();
 
@@ skipping 68 matching lines @@
                             ->render_manager()
                             ->current_frame_host()
                             ->GetSiteInstance()
                             ->GetId());
   if (iter == proxy_hosts_.end())
     return NULL;
 
   return iter->second;
 }
 
+RenderFrameProxyHost* RenderFrameHostManager::GetProxyToEmbedder() {
+  FrameTreeNode* embedder_frame_tree_node =
+      FrameTree::GloballyFindByID(pseudo_parent_frame_tree_node_id_);
+  if (!embedder_frame_tree_node)
+    return NULL;
+  RenderFrameProxyHostMap::iterator iter =
+      proxy_hosts_.find(embedder_frame_tree_node->render_manager()
+                            ->current_frame_host()->GetSiteInstance()
+                            ->GetId());
+  if (iter == proxy_hosts_.end())
+    return NULL;
+  return iter->second;
+}
+
 void RenderFrameHostManager::SetPendingWebUI(const GURL& url, int bindings) {
   pending_web_ui_ = CreateWebUI(url, bindings);
   pending_and_current_web_ui_.reset();
 }
 
 scoped_ptr<WebUIImpl> RenderFrameHostManager::CreateWebUI(const GURL& url,
                                                           int bindings) {
   scoped_ptr<WebUIImpl> new_web_ui(delegate_->CreateWebUIForRenderManager(url));
 
   // If we have assigned (zero or more) bindings to this NavigationEntry in the
@@ skipping 260 matching lines @@
   response_started_id_.reset();
 }
 
 void RenderFrameHostManager::ClearNavigationTransitionData() {
   render_frame_host_->ClearPendingTransitionRequestData();
 }
 
 void RenderFrameHostManager::DidNavigateFrame(
     RenderFrameHostImpl* render_frame_host,
     bool was_caused_by_user_gesture) {
+  if (render_frame_host->GetSiteInstance()->GetSiteURL().SchemeIs(

[Fady Samuel, 2015/03/04 22:21:06]

This doesn't work for other guest types such as <appview>.

[Charlie Reis, 2015/03/10 04:09:44]

Is RenderProcessHostImpl::IsIsolatedGuest() still valid?

[lazyboy, 2015/04/01 21:47:57]

I'm using GetProxyToEmbedder() instead, if we have a proxy, then we need the
Child RWHV.

+        "chrome-guest")) {
+    RenderFrameProxyHost* proxy_to_embedder = GetProxyToEmbedder();
+    DCHECK(proxy_to_embedder);
+    proxy_to_embedder->SetChildRWHView(current_host()->GetView());

[Charlie Reis, 2015/03/10 04:09:44]

This doesn't seem like the right place for these calls.  Should it be within
CommitPending?

[lazyboy, 2015/04/01 21:47:57]

Technically we don't have pending and don't commit pending.
However, with recent changes, this code has moved from ::DidNavigateFrame() to
::CommitPendingIfNecessary().

+    proxy_to_embedder->SetOverriddenParentFTNID(
+        pseudo_parent_frame_tree_node_id_);
+    current_host()->GetView()->Show();

[Fady Samuel, 2015/03/04 22:21:06]

This breaks visibility I think.

[lazyboy, 2015/04/01 21:47:57]

Added TODO to investigate.

+  }
+
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnableBrowserSideNavigation)) {
     if (render_frame_host == speculative_render_frame_host_.get()) {
       CommitPending();
     } else if (render_frame_host == render_frame_host_.get()) {
       // TODO(carlosk): this code doesn't properly handle in-page navigation or
       // interwoven navigation requests.
       DCHECK(!speculative_render_frame_host_);
     } else {
       // No one else should be sending us a DidNavigate in this state.
@@ skipping 1511 matching lines @@
 void RenderFrameHostManager::DeleteRenderFrameProxyHost(
     SiteInstance* instance) {
   RenderFrameProxyHostMap::iterator iter = proxy_hosts_.find(instance->GetId());
   if (iter != proxy_hosts_.end()) {
     delete iter->second;
     proxy_hosts_.erase(iter);
   }
 }
 
 }  // namespace content