Make <webview> use out-of-process iframe architecture.

content/browser/browser_plugin/browser_plugin_guest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// Note that all IPC sent out from this class will be dropped on the

[Fady Samuel, 2015/03/04 20:44:47]

I'd like to better understand what we do and don't need here.

+// floor b/c we don't have a BrowserPlugin anymore.
 #include "content/browser/browser_plugin/browser_plugin_guest.h"
 
 #include <algorithm>
 
 #include "base/message_loop/message_loop.h"
 #include "base/pickle.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/browser/browser_plugin/browser_plugin_embedder.h"
 #include "content/browser/browser_thread_impl.h"
 #include "content/browser/child_process_security_policy_impl.h"
@@ skipping 220 matching lines @@
              blink::WebFocusTypeNone);
 
   guest_visible_ = params.visible;
   UpdateVisibility();
 
   is_full_page_plugin_ = params.is_full_page_plugin;
   guest_window_rect_ = gfx::Rect(params.origin,
                                  params.resize_guest_params.view_size);
 
   if (owner_web_contents_ != owner_web_contents) {
-    WebContentsViewGuest* new_view =
-        static_cast<WebContentsViewGuest*>(GetWebContents()->GetView());
-    if (owner_web_contents_)
-      new_view->OnGuestDetached(owner_web_contents_->GetView());
+    // View is not created yet in the case if OOPIF
+    //WebContentsViewGuest* new_view =
+    //    static_cast<WebContentsViewGuest*>(GetWebContents()->GetView());
+    //if (owner_web_contents_)
+    //  new_view->OnGuestDetached(owner_web_contents_->GetView());
 
     // Once a BrowserPluginGuest has an embedder WebContents, it's considered to
     // be attached.
     owner_web_contents_ = owner_web_contents;
-    new_view->OnGuestAttached(owner_web_contents_->GetView());
+    //new_view->OnGuestAttached(owner_web_contents_->GetView());
   }
 
   RendererPreferences* renderer_prefs =
       GetWebContents()->GetMutableRendererPrefs();
   std::string guest_user_agent_override = renderer_prefs->user_agent_override;
   // Copy renderer preferences (and nothing else) from the embedder's
   // WebContents to the guest.
   //
   // For GTK and Aura this is necessary to get proper renderer configuration
   // values for caret blinking interval, colors related to selection and
@@ skipping 333 matching lines @@
         last_pending_frame_->producing_host_id,
         ack);
     last_pending_frame_.reset();
   }
   delegate_->WillAttach(embedder_web_contents, browser_plugin_instance_id,
                         params.is_full_page_plugin);
 
   // If a RenderView has already been created for this new window, then we need
   // to initialize the browser-side state now so that the RenderFrameHostManager
   // does not create a new RenderView on navigation.
-  if (has_render_view_) {
-    // This will trigger a callback to RenderViewReady after a round-trip IPC.
-    static_cast<RenderViewHostImpl*>(
-        GetWebContents()->GetRenderViewHost())->Init();
-    WebContentsViewGuest* web_contents_view =
-        static_cast<WebContentsViewGuest*>(GetWebContents()->GetView());
-    if (!web_contents()->GetRenderViewHost()->GetView()) {
-      web_contents_view->CreateViewForWidget(
-          web_contents()->GetRenderViewHost(), true);
-    }
-  }
+  //if (has_render_view_) {
+  //  // This will trigger a callback to RenderViewReady after a round-trip IPC.
+  //  static_cast<RenderViewHostImpl*>(
+  //      GetWebContents()->GetRenderViewHost())->Init();
+  //  WebContentsViewGuest* web_contents_view =
+  //      static_cast<WebContentsViewGuest*>(GetWebContents()->GetView());
+  //  if (!web_contents()->GetRenderViewHost()->GetView()) {
+  //    web_contents_view->CreateViewForWidget(
+  //        web_contents()->GetRenderViewHost(), true);
+  //  }
+  //}
 
   InitInternal(params, embedder_web_contents);
 
   attached_ = true;
   SendQueuedMessages();
 
   // Create a swapped out RenderView for the guest in the embedder render
   // process, so that the embedder can access the guest's window object.
   // On reattachment, we can reuse the same swapped out RenderView because
   // the embedder process will always be the same even if the embedder
   // WebContents changes.
-  if (guest_proxy_routing_id_ == MSG_ROUTING_NONE) {
-    guest_proxy_routing_id_ =
-        GetWebContents()->CreateSwappedOutRenderView(
-            owner_web_contents_->GetSiteInstance());
-  }
+  // Don't create the proxy here, we'll create it later.
+  //if (guest_proxy_routing_id_ == MSG_ROUTING_NONE) {
+  //  guest_proxy_routing_id_ =
+  //      GetWebContents()->CreateSwappedOutRenderView(
+  //          owner_web_contents_->GetSiteInstance());
+  //}
 
   delegate_->DidAttach(guest_proxy_routing_id_);
 
-  has_render_view_ = true;
+  //has_render_view_ = true;
 
-  // Enable input method for guest if it's enabled for the embedder.
-  if (static_cast<RenderViewHostImpl*>(
-      owner_web_contents_->GetRenderViewHost())->input_method_active()) {
-    RenderViewHostImpl* guest_rvh = static_cast<RenderViewHostImpl*>(
-        GetWebContents()->GetRenderViewHost());
-    guest_rvh->SetInputMethodActive(true);
-  }
+  //// Enable input method for guest if it's enabled for the embedder.
+  //if (static_cast<RenderViewHostImpl*>(
+  //    owner_web_contents_->GetRenderViewHost())->input_method_active()) {
+  //  RenderViewHostImpl* guest_rvh = static_cast<RenderViewHostImpl*>(
+  //      GetWebContents()->GetRenderViewHost());
+  //  guest_rvh->SetInputMethodActive(true);
+  //}
 
   RecordAction(base::UserMetricsAction("BrowserPlugin.Guest.Attached"));
 }
 
 void BrowserPluginGuest::OnCompositorFrameSwappedACK(
     int browser_plugin_instance_id,
     const FrameHostMsg_CompositorFrameSwappedACK_Params& params) {
   RenderWidgetHostImpl::SendSwapCompositorFrameAck(params.producing_route_id,
                                                    params.output_surface_id,
                                                    params.producing_host_id,
@@ skipping 248 matching lines @@
 void BrowserPluginGuest::OnImeCompositionRangeChanged(
       const gfx::Range& range,
       const std::vector<gfx::Rect>& character_bounds) {
   static_cast<RenderWidgetHostViewBase*>(
       web_contents()->GetRenderWidgetHostView())->ImeCompositionRangeChanged(
           range, character_bounds);
 }
 #endif
 
 }  // namespace content