Issue 9722040: Use absolute positioning for notification area.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9722040: Use absolute positioning for notification area. (Closed)

Created:
8 years, 9 months ago by Patrick Dubroy

Modified:
8 years, 9 months ago

Reviewers:
csilv, Nikita (slow), James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+watch_chromium.org, James Hawkins

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use absolute positioning for notification area. BUG=None TEST=Visual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128255 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128451

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -15 lines)			Patch
M	chrome/browser/resources/chromeos/login/login.html	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/oobe.css	View	1 chunk	+8 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/oobe.html	View	1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Patrick Dubroy

This is a follow-up to http://codereview.chromium.org/9416097/, which added the butter bar to the login screen. ...

8 years, 9 months ago (2012-03-19 15:27:55 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dubroy@chromium.org/9722040/1

8 years, 9 months ago (2012-03-20 13:40:00 UTC) #5

commit-bot: I haz the power

8 years, 9 months ago (2012-03-20 14:34:47 UTC) #6

Try job failure for 9722040-1 (retry) on win for step "compile" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Expand Messages | Collapse Messages