aura: Use platform independent skia::PlatformCanvas when possible.

ui/ui.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
   },
   'includes': [
     'ui_resources.gypi',
@@ skipping 355 matching lines @@
         'ui_controls/ui_controls_export.h',
         'ui_controls/ui_controls_internal_win.h',
         'ui_controls/ui_controls_internal_win.cc',
         'ui_controls/ui_controls_gtk.cc',
         'ui_controls/ui_controls_mac.mm',
         'ui_controls/ui_controls_win.cc',
       ],
       'conditions': [
         # TODO(asvitkine): Switch all platforms to use canvas_skia.cc.
         #                  http://crbug.com/105550
-        ['use_canvas_skia==1', {
+        ['use_canvas_skia==1 or use_aura==1', {

[piman, 2012/03/21 16:54:19]

I think it would be more maintainable to set use_canvas_skia in common.gypi
under the use_aura==1 condition.

[Alexei Svitkine (slow), 2012/03/21 16:59:20]

Actually, I agree on this front. Was a little trigger-happy on the LGTM.

Also, maybe make it a separate change to turn use_canvas_skia=1 on by default
for aura.

           'sources!': [
             'gfx/canvas_android.cc',
             'gfx/canvas_linux.cc',
             'gfx/canvas_mac.mm',
             'gfx/canvas_win.cc',
           ],
-        }, {  # use_canvas_skia!=1
+        }, {  # use_canvas_skia!=1 and use_aura!=1
           'sources!': [
             'gfx/canvas_skia.cc',
           ],
         }],
         ['use_aura==1', {
           'sources/': [
             ['exclude', 'gfx/gtk_'],
             ['exclude', 'gfx/gtk_util.cc'],
             ['exclude', 'gfx/gtk_util.h'],
             ['exclude', 'gfx/screen_gtk.cc'],
@@ skipping 300 matching lines @@
                 'shutil.copyfile(\'<(ui_copy_target)\', \'<(ui_copy_dest)\'); ' \
                 'os.chmod(\'<(ui_copy_dest)\', 0700)'
               ]
             }
           ],
         },
       ],
     }],
   ],
 }