Issue 9722025: Fix virtual memory regression from new tcmalloc: use old kPageShift and kMaxSize w/ kNumClasses = 5…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9722025: Fix virtual memory regression from new tcmalloc: use old kPageShift and kMaxSize w/ kNumClasses = 5… (Closed)

Created:
8 years, 9 months ago by Dai Mikurube (NOT FULLTIME)

Modified:
8 years, 9 months ago

Reviewers:
Dai Mikurube (NOT FULLTIME), jar (doing other things)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Fix virtual memory regression from new tcmalloc: use old kPageShift and kMaxSize w/ kNumClasses = 54. (retry of r127301) BUG=118329 TEST=perf tests. TBR=jar@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127381

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	third_party/tcmalloc/chromium/src/common.h	View		1 chunk	+8 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

Dai Mikurube (NOT FULLTIME)

Hi Jim, As I wrote in http://codereview.chromium.org/9699084/, keeping the latest common.cc and using old common.h ...

8 years, 9 months ago (2012-03-17 22:50:33 UTC) #2

jar (doing other things)

8 years, 9 months ago (2012-03-20 17:20:16 UTC) #3

LGTM

Nice detective work!  Thank you very much.