Extend dart:io error handling to all socket functions

runtime/bin/eventhandler_win.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/eventhandler.h"
 
 #include <process.h>
 #include <winsock2.h>
 #include <ws2tcpip.h>
 #include <mswsock.h>
@@ skipping 81 matching lines @@
 
 
 Handle::Handle(HANDLE handle)
     : handle_(reinterpret_cast<HANDLE>(handle)),
       flags_(0),
       port_(0),
       completion_port_(INVALID_HANDLE_VALUE),
       event_handler_(NULL),
       data_ready_(NULL),
       pending_read_(NULL),
-      pending_write_(NULL) {
+      pending_write_(NULL),
+      last_error_(NOERROR) {
   InitializeCriticalSection(&cs_);
 }
 
 
 Handle::Handle(HANDLE handle, Dart_Port port)
     : handle_(reinterpret_cast<HANDLE>(handle)),
       flags_(0),
       port_(port),
       completion_port_(INVALID_HANDLE_VALUE),
       event_handler_(NULL),
       data_ready_(NULL),
       pending_read_(NULL),
-      pending_write_(NULL) {
+      pending_write_(NULL),
+      last_error_(NOERROR) {
   InitializeCriticalSection(&cs_);
 }
 
 
 Handle::~Handle() {
   DeleteCriticalSection(&cs_);
 }
 
 
 void Handle::Lock() {
@@ skipping 588 matching lines @@
 
 
 void EventHandlerImplementation::HandleClosed(Handle* handle) {
   if (!handle->IsClosing()) {
     int event_mask = 1 << kCloseEvent;
     DartUtils::PostInt32(handle->port(), event_mask);
   }
 }
 
 
+void EventHandlerImplementation::HandleError(Handle* handle) {
+  handle->set_last_error(WSAGetLastError());
+  if (!handle->IsClosing()) {
+    int event_mask = 1 << kErrorEvent;
+    DartUtils::PostInt32(handle->port(), event_mask);
+  }
+}
+
+
 void EventHandlerImplementation::HandleRead(Handle* handle,
                                             int bytes,
                                             IOBuffer* buffer) {
   buffer->set_data_length(bytes);
   handle->ReadComplete(buffer);
   if (bytes > 0) {
     if (!handle->IsClosing()) {
       int event_mask = 1 << kInEvent;
       if ((handle->mask() & event_mask) != 0) {
         DartUtils::PostInt32(handle->port(), event_mask);
       }
     }
   } else {
-    ASSERT(bytes == 0);
     handle->MarkClosedRead();
-    HandleClosed(handle);
+    if (bytes == 0) {
+      HandleClosed(handle);
+    } else {
+      HandleError(handle);
+    }
   }
 
   if (handle->IsClosed()) {
     delete handle;
   }
 }
 
 
 void EventHandlerImplementation::HandleWrite(Handle* handle,
                                              int bytes,
                                              IOBuffer* buffer) {
   handle->WriteComplete(buffer);
 
   if (bytes > 0) {
     if (!handle->IsClosing()) {
       int event_mask = 1 << kOutEvent;
       if ((handle->mask() & event_mask) != 0) {
         DartUtils::PostInt32(handle->port(), event_mask);
       }
     }
+  } else if (bytes == 0) {
+    HandleClosed(handle);
   } else {
-    ASSERT(bytes == 0);
-    HandleClosed(handle);
+    HandleError(handle);
   }
 
   if (handle->IsClosed()) {
     delete handle;
   }
 }
 
 
 void EventHandlerImplementation::HandleTimeout() {
   // TODO(sgjesse) check if there actually is a timeout.
@@ skipping 82 matching lines @@
     if (!ok && overlapped == NULL) {
       if (GetLastError() == ERROR_ABANDONED_WAIT_0) {
         // The completion port should never be closed.
         printf("Completion port closed\n");
         UNREACHABLE();
       } else {
         // Timeout is signalled by false result and NULL in overlapped.
         handler->HandleTimeout();
       }
     } else if (!ok) {
-      // If GetQueuedCompletionStatus return false and overlapped is
-      // not NULL then it did dequeue a request which failed.
-
       // Treat ERROR_CONNECTION_ABORTED as connection closed.
       // The error ERROR_OPERATION_ABORTED is set for pending
       // accept requests for a listen socket which is closed.
       // ERROR_NETNAME_DELETED occurs when the client closes
       // the socket it is reading from.
       DWORD last_error = GetLastError();
       if (last_error == ERROR_CONNECTION_ABORTED ||
           last_error == ERROR_OPERATION_ABORTED ||
           last_error == ERROR_NETNAME_DELETED ||
           last_error == ERROR_BROKEN_PIPE) {
         ASSERT(bytes == 0);
         handler->HandleIOCompletion(bytes, key, overlapped);
       } else {
-        UNREACHABLE();
-     }
+        ASSERT(bytes == 0);
+        handler->HandleIOCompletion(-1, key, overlapped);
+      }
     } else if (key == NULL) {
       // A key of NULL signals an interrupt message.
       InterruptMessage* msg = reinterpret_cast<InterruptMessage*>(overlapped);
       handler->HandleInterrupt(msg);
       delete msg;
     } else {
       handler->HandleIOCompletion(bytes, key, overlapped);
     }
   }
 }
 
 
 void EventHandlerImplementation::StartEventHandler() {
   int result = dart::Thread::Start(EventHandlerThread,
                                    reinterpret_cast<uword>(this));
   if (result != 0) {
     FATAL1("Failed to start event handler thread %d", result);
   }
 
   // Initialize Winsock32
   if (!Socket::Initialize()) {
     FATAL("Failed to initialized Windows sockets");
   }
 }