Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: printing/backend/print_backend_win.cc

Issue 9720029: Fixed invalid return value. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/backend/print_backend_win.cc
diff --git a/printing/backend/print_backend_win.cc b/printing/backend/print_backend_win.cc
index 30da70e2fd581db9be637ff4a408650af4a0d616..bed2c67557138c3304c453b71ee43f17c24d2ade 100644
--- a/printing/backend/print_backend_win.cc
+++ b/printing/backend/print_backend_win.cc
@@ -183,20 +183,20 @@ std::string PrintBackendWin::GetPrinterDriverInfo(
ScopedPrinterHandle printer_handle;
if (!::OpenPrinter(const_cast<LPTSTR>(UTF8ToWide(printer_name).c_str()),
printer_handle.Receive(), NULL)) {
- return false;
+ return driver_info;
}
DCHECK(printer_handle.IsValid());
DWORD bytes_needed = 0;
::GetPrinterDriver(printer_handle, NULL, 6, NULL, 0, &bytes_needed);
scoped_array<BYTE> driver_info_buffer(new BYTE[bytes_needed]);
if (!bytes_needed || !driver_info_buffer.get())
- return false;
+ return driver_info;
if (!::GetPrinterDriver(printer_handle, NULL, 6, driver_info_buffer.get(),
bytes_needed, &bytes_needed)) {
- return false;
+ return driver_info;
}
if (!bytes_needed)
- return false;
+ return driver_info;
const DRIVER_INFO_6* driver_info_6 =
reinterpret_cast<DRIVER_INFO_6*>(driver_info_buffer.get());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698