Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9720019: Use scoped_ptr<> to pass ownership in more places. (Closed)

Created:
8 years, 9 months ago by Sergey Ulanov
Modified:
8 years, 9 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Use scoped_ptr<> to pass ownership in more places. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127767

Patch Set 1 : #

Patch Set 2 : - #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -166 lines) Patch
M remoting/base/codec_test.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M remoting/base/encoder.h View 1 chunk +1 line, -3 lines 0 comments Download
M remoting/base/encoder_row_based.cc View 3 chunks +7 lines, -9 lines 0 comments Download
M remoting/base/encoder_vp8.cc View 1 chunk +14 lines, -14 lines 0 comments Download
M remoting/base/encoder_vp8_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/host/chromoting_host.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/chromoting_host_unittest.cc View 1 2 3 chunks +10 lines, -6 lines 0 comments Download
M remoting/host/client_session.h View 1 chunk +1 line, -3 lines 0 comments Download
M remoting/host/client_session.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/client_session_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M remoting/host/continue_window.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/continue_window_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/continue_window_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/continue_window_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/disconnect_window.h View 2 chunks +3 lines, -1 line 0 comments Download
M remoting/host/disconnect_window_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/disconnect_window_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/disconnect_window_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/event_executor.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/heartbeat_sender.h View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/host_mock_objects.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M remoting/host/it2me_host_user_interface.h View 1 chunk +4 lines, -5 lines 0 comments Download
M remoting/host/it2me_host_user_interface.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M remoting/host/local_input_monitor.h View 2 chunks +3 lines, -1 line 0 comments Download
M remoting/host/local_input_monitor_linux.cc View 3 chunks +13 lines, -10 lines 0 comments Download
M remoting/host/local_input_monitor_mac.mm View 3 chunks +10 lines, -6 lines 0 comments Download
M remoting/host/local_input_monitor_win.cc View 2 chunks +14 lines, -12 lines 0 comments Download
M remoting/host/log_to_server.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/register_support_host_request.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/screen_recorder.h View 3 chunks +4 lines, -8 lines 0 comments Download
M remoting/host/screen_recorder.cc View 4 chunks +21 lines, -31 lines 0 comments Download
M remoting/host/screen_recorder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/server_log_entry.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M remoting/host/server_log_entry.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/host/server_log_entry_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sergey Ulanov
8 years, 9 months ago (2012-03-17 01:24:47 UTC) #1
Alpha Left Google
http://codereview.chromium.org/9720019/diff/5001/remoting/host/chromoting_host_unittest.cc File remoting/host/chromoting_host_unittest.cc (right): http://codereview.chromium.org/9720019/diff/5001/remoting/host/chromoting_host_unittest.cc#newcode197 remoting/host/chromoting_host_unittest.cc:197: base::Unretained(client), connection.get())); Isn't this connection.get() will be NULL since ...
8 years, 9 months ago (2012-03-20 18:56:40 UTC) #2
Sergey Ulanov
http://codereview.chromium.org/9720019/diff/5001/remoting/host/chromoting_host_unittest.cc File remoting/host/chromoting_host_unittest.cc (right): http://codereview.chromium.org/9720019/diff/5001/remoting/host/chromoting_host_unittest.cc#newcode197 remoting/host/chromoting_host_unittest.cc:197: base::Unretained(client), connection.get())); On 2012/03/20 18:56:40, Alpha wrote: > Isn't ...
8 years, 9 months ago (2012-03-20 19:08:12 UTC) #3
Alpha Left Google
LGTM. On 2012/03/20 19:08:12, sergeyu wrote: > http://codereview.chromium.org/9720019/diff/5001/remoting/host/chromoting_host_unittest.cc > File remoting/host/chromoting_host_unittest.cc (right): > > http://codereview.chromium.org/9720019/diff/5001/remoting/host/chromoting_host_unittest.cc#newcode197 ...
8 years, 9 months ago (2012-03-20 19:09:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/9720019/10002
8 years, 9 months ago (2012-03-20 19:18:52 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-20 20:31:47 UTC) #6 
Change committed as 127767

Powered by Google App Engine
This is Rietveld 408576698