Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1282)

Unified Diff: dart/frog/leg/lib/string_helper.dart

Issue 9719034: Interceptor maintenance: (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/leg/lib/js_helper.dart ('k') | dart/tests/corelib/corelib-leg.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/lib/string_helper.dart
diff --git a/dart/frog/leg/lib/string_helper.dart b/dart/frog/leg/lib/string_helper.dart
index 9cc3e37ec73059ff50cf8c255bb36529ced8c70f..a230ae30d97be7b2e8973b9fd7e125bfbe7be555 100644
--- a/dart/frog/leg/lib/string_helper.dart
+++ b/dart/frog/leg/lib/string_helper.dart
@@ -88,6 +88,7 @@ stringReplaceAllUnchecked(receiver, from, to) {
var re = new RegExpWrapper.fromRegExp(from, true).re;
return JS('String', @'#.replace(#, #)', receiver, re, to);
} else {
+ checkNull(from);
// TODO(floitsch): implement generic String.replace (with patterns).
throw "StringImplementation.replaceAll(Pattern) UNIMPLEMENTED";
}
@@ -100,6 +101,7 @@ stringReplaceFirstUnchecked(receiver, from, to) {
var re = new RegExpWrapper.fromRegExp(from, false).re;
return JS('String', @'#.replace(#, #)', receiver, re, to);
} else {
+ checkNull(from);
// TODO(floitsch): implement generic String.replace (with patterns).
throw "StringImplementation.replace(Pattern) UNIMPLEMENTED";
}
« no previous file with comments | « dart/frog/leg/lib/js_helper.dart ('k') | dart/tests/corelib/corelib-leg.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698