Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: dart/frog/leg/resolver.dart

Issue 9719017: Fixed a few typos. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Include test Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/tests/language/src/ThisTest.dart » ('j') | dart/tests/language/src/ThisTest.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/resolver.dart
diff --git a/dart/frog/leg/resolver.dart b/dart/frog/leg/resolver.dart
index 224473c1d17198c21b2564c2a369662346887a98..5b46fd06be68e839b0ab84877f9fecb91a57b904 100644
--- a/dart/frog/leg/resolver.dart
+++ b/dart/frog/leg/resolver.dart
@@ -754,8 +754,7 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {
}
Element resolveSend(Send node) {
- if (node.receiver === null || (node.selector.asIdentifier() !== null &&
- node.selector.asIdentifier().isThis())) {
+ if (node.receiver === null) {
return node.selector.accept(this);
}
var oldCategory = allowedCategory;
@@ -766,7 +765,9 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {
Element target;
SourceString name = node.selector.asIdentifier().source;
- if (node.isSuperCall) {
+ if (name.stringValue === 'this') {
+ error(node.selector, MessageKind.GENERIC, ["expected an identifier"]);
+ } else if (node.isSuperCall) {
if (isUserDefinableOperator(name.stringValue)) {
name = Elements.constructOperatorName(const SourceString('operator'),
name);
@@ -778,7 +779,7 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {
if (currentClass.supertype === null) {
// This is just to guard against internal errors, so no need
// for a real error message.
- error(node.receiver, MessageKind.GENERIC, "Object has no superclass");
+ error(node.receiver, MessageKind.GENERIC, ["Object has no superclass"]);
}
target = currentClass.lookupSuperMember(name);
// [target] may be null which means invoking noSuchMethod on
« no previous file with comments | « no previous file | dart/tests/language/src/ThisTest.dart » ('j') | dart/tests/language/src/ThisTest.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698