Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1830)

Unified Diff: frog/leg/resolver.dart

Issue 9718034: Continue for simple loops (while/for). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | frog/leg/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/leg/resolver.dart
diff --git a/frog/leg/resolver.dart b/frog/leg/resolver.dart
index 3b3e8a64243d28a4ddc0401f62023f8723c55175..7cf4d9c4f55b7b9741004451716f387abf05eb60 100644
--- a/frog/leg/resolver.dart
+++ b/frog/leg/resolver.dart
@@ -656,7 +656,7 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {
if (element.kind == ElementKind.FIELD_PARAMETER) {
useElement(parameterNode, element);
} else {
- defineElement(variableDefinitions.definitions.nodes.head, element);
+ defineElement(variableDefinitions.definitions.nodes.head, element);
}
parameterNodes = parameterNodes.tail;
});
@@ -1089,9 +1089,9 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {
warning(existingElement.label, MessageKind.EXISTING_LABEL, [labelName]);
}
Node body = node.getBody();
- TargetElement TargetElement = getOrCreateTargetElement(body);
+ TargetElement targetElement = getOrCreateTargetElement(body);
- LabelElement element = TargetElement.addLabel(node.label, labelName);
+ LabelElement element = targetElement.addLabel(node.label, labelName);
statementScope.enterLabelScope(element);
visit(node.statement);
statementScope.exitLabelScope();
@@ -1100,9 +1100,9 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {
} else {
warning(node.label, MessageKind.UNUSED_LABEL, [labelName]);
}
- if (!TargetElement.isBreakTarget && mapping[body] === TargetElement) {
+ if (!targetElement.isTarget && mapping[body] === targetElement) {
// If the body is itself a break or continue for another target, it
- // might have updated its mapping to the label it actaully does target.
+ // might have updated its mapping to the target it actually does target.
mapping.remove(body);
}
}
@@ -1524,7 +1524,7 @@ class SignatureResolver extends CommonResolverVisitor<Element> {
Element variables = new VariableListElement.node(currentDefinitions,
ElementKind.VARIABLE_LIST, enclosingElement);
element = new FieldParameterElement(node.selector.asIdentifier().source,
- fieldElement, variables, enclosingElement, node);
+ fieldElement, variables, enclosingElement, node);
}
return element;
}
« no previous file with comments | « no previous file | frog/leg/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698