Allow autoupdate to update disabled extensions.

chrome/browser/extensions/updater/extension_updater.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_UPDATER_EXTENSION_UPDATER_H_
 #define CHROME_BROWSER_EXTENSIONS_UPDATER_EXTENSION_UPDATER_H_
 #pragma once
 
 #include <set>
 #include <stack>
 #include <string>
 
 #include "base/compiler_specific.h"
 #include "base/file_path.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/time.h"
 #include "base/timer.h"
 #include "chrome/browser/extensions/updater/extension_downloader_delegate.h"
 #include "chrome/browser/extensions/updater/manifest_fetch_data.h"
+#include "chrome/common/extensions/extension_set.h"

[asargent_no_longer_on_chrome, 2012/03/20 00:24:01]

Can you just forward declare ExtensionSet and skip the include here?

http://dev.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Forward...

[Matt Tytel, 2012/03/20 20:34:28]

Done.

 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "googleurl/src/gurl.h"
 
 class ExtensionPrefs;
 class ExtensionServiceInterface;
 class PrefService;
 class Profile;
 
 namespace extensions {
@@ skipping 29 matching lines @@
   void Start();
 
   // Stops the updater running, cancelling any outstanding update manifest and
   // crx downloads. Does not cancel any in-progress installs.
   void Stop();
 
   // Posts a task to do an update check.  Does nothing if there is
   // already a pending task that has not yet run.
   void CheckSoon();
 
+  // Add fetch records for extensions that are installed and have an
+  // update URL to the downloader, ignoring |pending_ids| so the extension isn't
+  // fetched again.
+  void AddToDownloader(const ExtensionSet* extensions,
+                       const std::set<std::string>& pending_ids);

[asargent_no_longer_on_chrome, 2012/03/20 00:24:01]

Any reason not to have this be private? (Typically helper methods that aren't
called outside a class should be)

[Matt Tytel, 2012/03/20 20:34:28]

Done.

+
   // Starts an update check right now, instead of waiting for the next
   // regularly scheduled check or a pending check from CheckSoon().
   void CheckNow();
 
   // Set blacklist checks on or off.
   void set_blacklist_checks_enabled(bool enabled) {
     blacklist_checks_enabled_ = enabled;
   }
 
   // Returns true iff CheckSoon() has been called but the update check
@@ skipping 107 matching lines @@
 
   // Fetched CRX files waiting to be installed.
   std::stack<FetchedCRXFile> fetched_crx_files_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionUpdater);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_UPDATER_EXTENSION_UPDATER_H_