Load the metro driver dll at startup

Load the metro driver dll at startup

When the metro_driver is present, we need to relinquish the browser main
thread to it, execution of chrome will continue on another thread, which
will be used as chrome main thread.

TEST=none, other that chrome should work.
BUG=118641
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127714

[darin (slow to review), 2012-03-16 21:12:56]

http://codereview.chromium.org/9718001/diff/1/chrome/app/chrome_exe_main_win.cc
File chrome/app/chrome_exe_main_win.cc (right):

http://codereview.chromium.org/9718001/diff/1/chrome/app/chrome_exe_main_win....
chrome/app/chrome_exe_main_win.cc:16: namespace {
nit: new line after namespace open

http://codereview.chromium.org/9718001/diff/1/chrome/app/chrome_exe_main_win....
chrome/app/chrome_exe_main_win.cc:18: // this environment variable controls the
loading of the metro driver DLL.
brett-nit: "this" -> "This"

http://codereview.chromium.org/9718001/diff/1/chrome/app/chrome_exe_main_win....
chrome/app/chrome_exe_main_win.cc:49: class MetroDriver {
feels like this should be in a file of its own

http://codereview.chromium.org/9718001/diff/1/chrome/app/chrome_exe_main_win....
chrome/app/chrome_exe_main_win.cc:91: }  // namespace
nit: new line before namespace close

[cpu_(ooo_6.6-7.5), 2012-03-19 01:40:30]

refactored into files, please take a look again.

[darin (slow to review), 2012-03-19 16:30:45]

LGTM

http://codereview.chromium.org/9718001/diff/7001/chrome/app/metro_driver_win.cc
File chrome/app/metro_driver_win.cc (right):

http://codereview.chromium.org/9718001/diff/7001/chrome/app/metro_driver_win....
chrome/app/metro_driver_win.cc:4: #include "metro_driver_win.h"
nit: new line above here

http://codereview.chromium.org/9718001/diff/7001/chrome/app/metro_driver_win....
chrome/app/metro_driver_win.cc:6: #include <windows.h>
nit: already have this include from the header file

http://codereview.chromium.org/9718001/diff/7001/chrome/app/metro_driver_win....
chrome/app/metro_driver_win.cc:11: typedef int
(*InitMetro)(LPTHREAD_START_ROUTINE thread_proc, void* context);
nit: recommend placing typedef apart from the constants

http://codereview.chromium.org/9718001/diff/7001/chrome/app/metro_driver_win.h
File chrome/app/metro_driver_win.h (right):

http://codereview.chromium.org/9718001/diff/7001/chrome/app/metro_driver_win....
chrome/app/metro_driver_win.h:10: typedef int (*MainFn)(HINSTANCE instance);
nit: put this typedef inside the MetroDriver class.

http://codereview.chromium.org/9718001/diff/7001/chrome/app/metro_driver_win....
chrome/app/metro_driver_win.h:18: MetroDriver();
nit: new line after here

[commit-bot: I haz the power, 2012-03-19 18:51:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cpu@chromium.org/9718001/9006

[commit-bot: I haz the power, 2012-03-19 20:34:47]

Try job failure for 9718001-9006 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-03-20 00:46:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cpu@chromium.org/9718001/9006

[commit-bot: I haz the power, 2012-03-20 03:21:31]

Try job failure for 9718001-9006 (retry) on win_rel for steps "ui_tests,
browser_tests".
It's a second try, previously, steps "ui_tests, browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...