Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: media/base/composite_filter.cc

Issue 9717021: Make Callback::Reset() return a copy to support use-cases where Run() ends up modifying |*this|. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/composite_filter.cc
diff --git a/media/base/composite_filter.cc b/media/base/composite_filter.cc
index d766948b0fcb24f2503895160d3c008ab2ca5b70..ebf44c2dd23b84590a12a01ffaabb76a27bd5cb1 100644
--- a/media/base/composite_filter.cc
+++ b/media/base/composite_filter.cc
@@ -290,14 +290,14 @@ void CompositeFilter::DispatchPendingCallback(PipelineStatus status) {
DCHECK(status_cb_.is_null() ^ callback_.is_null());
if (!status_cb_.is_null()) {
- ResetAndRunCB(&status_cb_, status);
+ status_cb_.ResetAndRun(status);
return;
}
if (!callback_.is_null()) {
if (status != PIPELINE_OK)
SendErrorToHost(status);
- ResetAndRunCB(&callback_);
+ callback_.ResetAndRun();
}
}

Powered by Google App Engine
This is Rietveld 408576698