Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 9716030: Prepare push to trunk. Now working on version 3.9.21. (Closed)

Created:
8 years, 9 months ago by rossberg
Modified:
8 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Prepare push to trunk. Now working on version 3.9.21. R=jkummerow@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11078

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M ChangeLog View 1 chunk +25 lines, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
rossberg
8 years, 9 months ago (2012-03-19 09:33:25 UTC) #1
Jakob Kummerow
8 years, 9 months ago (2012-03-19 09:36:19 UTC) #2
LGTM with a nit: we prefer to use the past tense ("Fixed", "Added" etc) in
ChangeLog entries.

Powered by Google App Engine
This is Rietveld 408576698