Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 9716003: Extract ExtensionFunctionRegistry from ExtensionFunctionDispatcher. (Closed)

Created:
8 years, 9 months ago by miket_OOO
Modified:
8 years, 9 months ago
CC:
chromium-reviews, Aaron Boodman, pam+watch_chromium.org, mihaip+watch_chromium.org
Visibility:
Public.

Description

Reapply 127159 (http://codereview.chromium.org/9666059) plus important fixes. Refactor extension_function_dispatcher to extract ExtensionFunctionRegistry. This allows us to generate an additional code block that takes an ExtensionFunctionRegistry and asks it to register generated API functions. Then switch DnsResolve over to get registered this way. Along the way, notice that DNSResolve is capitalized using an untenable style. Fix that. Fixes since original 127159: - change name of build rule to gen_bundle_api - actually add per-file dependencies to .gyp (this was why clean builds failed) - change 'outputs' to match the emitted filename, fixing a needless rebuild problem. - split the top-level build action that was a part of json_schema_compile.gypi, and include it only in api.gyp, thus fixing the problem where json_schema_compiler_tests.gyp was asking it to create outputs in the tools/json_schema_compiler_test directory, again causing needless work during the build process. BUG=none (essential plumbing work) TEST=same as before. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127555

Patch Set 1 #

Patch Set 2 : Changes since original 127159. #

Patch Set 3 : Nits; fix Windows build (thanks Brad Nelson!). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+367 lines, -939 lines) Patch
A build/json_schema_bundle_compile.gypi View 1 2 1 chunk +66 lines, -0 lines 0 comments Download
M build/json_schema_compile.gypi View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/dns/dns_api.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/dns/dns_api.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/dns/dns_apitest.cc View 7 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 2 4 chunks +7 lines, -533 lines 0 comments Download
A chrome/browser/extensions/extension_function_registry.h View 1 chunk +56 lines, -0 lines 0 comments Download
A + chrome/browser/extensions/extension_function_registry.cc View 1 2 8 chunks +19 lines, -334 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M tools/json_schema_compiler/compiler.py View 4 chunks +72 lines, -23 lines 0 comments Download
M tools/json_schema_compiler/cpp_type_generator.py View 1 chunk +4 lines, -3 lines 0 comments Download
M tools/json_schema_compiler/cpp_util.py View 3 chunks +13 lines, -0 lines 0 comments Download
A tools/json_schema_compiler/h_bundle_generator.py View 1 chunk +79 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/h_generator.py View 2 chunks +2 lines, -11 lines 0 comments Download
M tools/json_schema_compiler/test/json_schema_compiler_tests.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
asargent_no_longer_on_chrome
lgtm
8 years, 9 months ago (2012-03-16 20:27:50 UTC) #1
bradn
8 years, 9 months ago (2012-03-19 19:04:31 UTC) #2
By the way, it looks like the ONLY instance of 'idl' rules that doesn't use msvs
idl has msvs_external_rule turned on, so that strongly suggests it may be broken
without.

Powered by Google App Engine
This is Rietveld 408576698