Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 9709001: Remove/add log for timeout issue. (Closed)

Created:
8 years, 9 months ago by oshima
Modified:
8 years, 9 months ago
CC:
chromium-reviews, Nirnimesh, John Grabowski, jam, joi+watch-content_chromium.org, anantha, darin-cc_chromium.org, dyu1, dennis_jeffrey
Visibility:
Public.

Description

Remove resource_dispatcher_host from --vmodule in pyauto.py. Add logs between LoadURL and DidStartLoading. Failing test has no DidStartLoading (in RVHImpl) in failing test, so the request must be lost somewhere. This will tell us where the request gets lost. BUG=chromium-os:26646 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126854

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : add bug # #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M chrome/browser/chromeos/login/webui_login_display_host.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/pyautolib/pyauto.py View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 3 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
oshima
jam -> contents davemoore -> chrome/browser/chroemos/login sky -> chrome/test
8 years, 9 months ago (2012-03-14 21:23:39 UTC) #1
sky
Nirnimesh should review this. I've removed myself and added him.
8 years, 9 months ago (2012-03-14 22:24:52 UTC) #2
dennis_jeffrey
Changes to chrome/test/pyautolib/pyauto.py LGTM (Nirnimesh is OOO and I'm taking care of pyauto changes until ...
8 years, 9 months ago (2012-03-14 22:31:00 UTC) #3
jam
lgtm the change says "Remove vlog for resource_dispatcher_host" but I don't see that
8 years, 9 months ago (2012-03-15 01:51:16 UTC) #4
oshima
On 2012/03/15 01:51:16, John Abd-El-Malek wrote: > lgtm > > the change says "Remove vlog ...
8 years, 9 months ago (2012-03-15 02:09:07 UTC) #5
DaveMoore
lgtm modulo nit http://codereview.chromium.org/9709001/diff/1001/content/browser/renderer_host/render_view_host_impl.cc File content/browser/renderer_host/render_view_host_impl.cc (right): http://codereview.chromium.org/9709001/diff/1001/content/browser/renderer_host/render_view_host_impl.cc#newcode280 content/browser/renderer_host/render_view_host_impl.cc:280: #if defined(OS_CHROMEOS) Nit: missing bug #
8 years, 9 months ago (2012-03-15 02:15:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/9709001/8001
8 years, 9 months ago (2012-03-15 02:30:13 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-15 04:39:42 UTC) #8
Try job failure for 9709001-8001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Powered by Google App Engine
This is Rietveld 408576698