Issue 9707001: Ash: Use new toolbar buttons, adjust spacing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9707001: Ash: Use new toolbar buttons, adjust spacing (Closed)

Created:
8 years, 9 months ago by James Cook

Modified:
8 years, 9 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Ash: Use new toolbar buttons, adjust spacing The new button assets have sharper edges, which better matches the look of the frame. They are also more tightly spaced. BUG=117433 TEST=visual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126710

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+142 lines, -42 lines)			Patch
M	chrome/app/theme/theme_resources_standard.grd	View	1	6 chunks	+93 lines, -33 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/location_bar_view.cc	View	1	3 chunks	+31 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/toolbar_view.cc	View	1	1 chunk	+18 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

James Cook

Ben, PTAL. We'll need to update the icons that appear inside the location bar in ...

8 years, 9 months ago (2012-03-14 18:58:19 UTC) #1

Ben Goodger (Google)

8 years, 9 months ago (2012-03-14 19:00:14 UTC) #2

LGTM provided:

you add a todo to the .cc referencing a bug to update Chrome on other platforms
in Mstone-20