Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 9706076: Deprecate installing 32bit build dependencies on a 64bit (Closed)

Created:
8 years, 9 months ago by Markus (顧孟勤)
Modified:
8 years, 9 months ago
Reviewers:
tony, Michael Moss
CC:
chromium-reviews
Visibility:
Public.

Description

Deprecate installing 32bit build dependencies on a 64bit system. Instead, point the developer towards the install-chroot.sh script, which is a cleaner way to achieve the same goal. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126989

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M build/install-build-deps.sh View 1 2 chunks +12 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Markus (顧孟勤)
8 years, 9 months ago (2012-03-15 20:40:10 UTC) #1
tony
LGTM https://chromiumcodereview.appspot.com/9706076/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): https://chromiumcodereview.appspot.com/9706076/diff/1/build/install-build-deps.sh#newcode221 build/install-build-deps.sh:221: echo "install-build-deps.sh. N.B. this code is no longer ...
8 years, 9 months ago (2012-03-15 20:45:56 UTC) #2
Markus (顧孟勤)
Changed the warning, so it will only be displayed if you actually attempt to install ...
8 years, 9 months ago (2012-03-15 20:56:19 UTC) #3
tony
8 years, 9 months ago (2012-03-15 22:03:04 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698