Issue 9706063: ash: A number of ui/ux changes from feedback/to better match the mocks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9706063: ash: A number of ui/ux changes from feedback/to better match the mocks. (Closed)

Created:
8 years, 9 months ago by sadrul

Modified:
8 years, 9 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: A number of ui/ux changes from feedback/to better match the mocks. The changes: * The network list scrolls on mouse-wheel. * The items in the network list cover the whole width of the list. * Increase the font-size of the date in the tray. * Adjust spacing between items in the tray. * Adjust padding in the user card. * Adjust the spacing and border around the shutdown etc. buttons in the user card. * Fix a crash from non-ascii username/email address. BUG=110130, 118326 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126955

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -23 lines)			Patch
M	ash/shell.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ash/system/network/tray_network.cc	View	2 chunks	+20 lines, -1 line	0 comments	Download
M	ash/system/power/tray_power_date.cc	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	ash/system/tray/system_tray.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	ash/system/tray/tray_constants.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/system/tray/tray_constants.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/system/user/tray_user.cc	View	8 chunks	+38 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages