Issue 9706059: Centralizes snap sizing and implements spec'd behavior. Three resize

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9706059: Centralizes snap sizing and implements spec'd behavior. Three resize (Closed)

Created:
8 years, 9 months ago by sky

Modified:
8 years, 9 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Centralizes snap sizing and implements spec'd behavior. Three resize stops: .5, 2/3, .8. You get to the next stop by pausing them moving, or moving enough. BUG=116213 TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126932

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+315 lines, -142 lines)			Patch
M	ash/ash.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ash/wm/workspace/frame_maximize_button.h	View		3 chunks	+11 lines, -6 lines	0 comments	Download
M	ash/wm/workspace/frame_maximize_button.cc	View		9 chunks	+37 lines, -16 lines	0 comments	Download
A	ash/wm/workspace/snap_sizer.h	View	1	1 chunk	+90 lines, -0 lines	0 comments	Download
A	ash/wm/workspace/snap_sizer.cc	View	1	1 chunk	+120 lines, -0 lines	0 comments	Download
M	ash/wm/workspace/workspace_window_resizer.h	View		5 chunks	+19 lines, -36 lines	0 comments	Download
M	ash/wm/workspace/workspace_window_resizer.cc	View		6 chunks	+36 lines, -84 lines	0 comments	Download

Total messages: 2 (0 generated)

Ben Goodger (Google)

8 years, 9 months ago (2012-03-15 16:09:21 UTC) #2

LGTM. once we're happy with this snap_sizer seems unit-testable too.