Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.cc

Issue 9706044: Ash: Extend tabs to top of window for maximized windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Just push tabs to top Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/frame_painter.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.cc
diff --git a/chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.cc b/chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.cc
index 16def5252cc5ab05a4c2d23a3a0fb07d6cacf84d..c9a6d8c3b973fa1dfc7106a005045627a4e6f7bf 100644
--- a/chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.cc
+++ b/chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.cc
@@ -32,7 +32,9 @@ const int kTabstripRightSpacing = 10;
// Space between top of window and top of tabstrip for restored windows.
const int kTabstripTopSpacingRestored = 10;
// Space between top of window and top of tabstrip for maximized windows.
-const int kTabstripTopSpacingMaximized = 1;
+// Place them flush to the top to make them clickable when the cursor is at
+// the screen edge.
+const int kTabstripTopSpacingMaximized = 0;
} // namespace
@@ -81,9 +83,8 @@ gfx::Rect BrowserNonClientFrameViewAura::GetBoundsForTabStrip(
views::View* tabstrip) const {
if (!tabstrip)
return gfx::Rect();
- bool restored = !frame()->IsMaximized();
return gfx::Rect(kTabstripLeftSpacing,
- GetHorizontalTabStripVerticalOffset(restored),
+ GetHorizontalTabStripVerticalOffset(false),
James Cook 2012/03/15 17:31:12 This function doesn't take the *current* restored
std::max(0, maximize_button_->x() - kTabstripRightSpacing),
tabstrip->GetPreferredSize().height());
}
« no previous file with comments | « ash/wm/frame_painter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698