Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5397)

Unified Diff: chrome/browser/resources/shared/js/cr/ui/overlay.js

Issue 9706031: Settings: Fix a few overlays that set min-width on the list directly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/shared/js/cr/ui/overlay.js
diff --git a/chrome/browser/resources/shared/js/cr/ui/overlay.js b/chrome/browser/resources/shared/js/cr/ui/overlay.js
index 09086e266a0de40a1108f58d9d59aafd899cbb29..d91aeaa04105084c418b41dbd1a0ac85afb16611 100644
--- a/chrome/browser/resources/shared/js/cr/ui/overlay.js
+++ b/chrome/browser/resources/shared/js/cr/ui/overlay.js
@@ -25,11 +25,8 @@ cr.define('cr.ui.overlay', function() {
// visible overlay .page.
document.addEventListener('focus', function(e) {
var overlay = getTopOverlay();
- if (!overlay)
- return;
-
- var page = overlay.querySelector('.page:not([hidden])');
- if (page.contains(e.target))
+ var page = overlay ? overlay.querySelector('.page:not([hidden])') : null;
+ if (!page || page.contains(e.target))
return;
var focusElement = page.querySelector('button, input, list, select, a');
@@ -50,10 +47,10 @@ cr.define('cr.ui.overlay', function() {
window.addEventListener('resize', function() {
var overlay = getTopOverlay();
- if (!overlay)
+ var page = overlay ? overlay.querySelector('.page:not([hidden])') : null;
+ if (!page)
return;
- var page = overlay.querySelector('.page:not([hidden])');
page.style.maxHeight = Math.min(0.9 * window.innerHeight, 640) + 'px';
});
}

Powered by Google App Engine
This is Rietveld 408576698