Settings: Fix a few overlays that set min-width on the list directly.

chrome/browser/resources/shared/js/cr/ui/overlay.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file exists to share common overlay behaviors.
 
 cr.define('cr.ui.overlay', function() {
 
   /**
    * Gets the top, visible overlay. It makes the assumption that if multiple
    * overlays are visible, the last in the byte order is topmost.
    * TODO(estade): rely on aria-visibility instead?
    * @return {HTMLElement} The overlay.
    */
   function getTopOverlay() {
     var overlays = document.querySelectorAll('.overlay:not([hidden])');
     return overlays[overlays.length - 1];
   }
 
   /**
    * Makes initializations which must hook at the document level.
    */
   function globalInitialization() {
     // Listen to focus events and make sure focus doesn't move outside of a
     // visible overlay .page.
     document.addEventListener('focus', function(e) {
       var overlay = getTopOverlay();
-      if (!overlay)
-        return;
-
-      var page = overlay.querySelector('.page:not([hidden])');
-      if (page.contains(e.target))
+      var page = overlay ? overlay.querySelector('.page:not([hidden])') : null;
+      if (!page || page.contains(e.target))
         return;
 
       var focusElement = page.querySelector('button, input, list, select, a');
       if (focusElement)
         focusElement.focus();
     }, true);
 
     // Close the overlay on escape.
     document.addEventListener('keydown', function(e) {
       if (e.keyCode == 27) {  // Escape
         var overlay = getTopOverlay();
         if (!overlay)
           return;
 
         cr.dispatchSimpleEvent(overlay, 'cancelOverlay');
       }
     });
 
     window.addEventListener('resize', function() {
       var overlay = getTopOverlay();
-      if (!overlay)
+      var page = overlay ? overlay.querySelector('.page:not([hidden])') : null;
+      if (!page)
         return;
 
-      var page = overlay.querySelector('.page:not([hidden])');
       page.style.maxHeight = Math.min(0.9 * window.innerHeight, 640) + 'px';
     });
   }
 
   /**
    * Adds behavioral hooks for the given overlay.
    * @param {HTMLElement} overlay The .overlay.
    */
   function setupOverlay(overlay) {
     // Close the overlay on clicking any of the pages' close buttons.
@@ skipping 33 matching lines @@
   }
 
   return {
     globalInitialization: globalInitialization,
     setupOverlay: setupOverlay,
   }
 });
 
 document.addEventListener('DOMContentLoaded',
                           cr.ui.overlay.globalInitialization);