Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 9706007: ash: Update the volume icon when audio is muted/unmuted. (Closed)

Created:
8 years, 9 months ago by sadrul
Modified:
8 years, 9 months ago
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

ash: Update the volume icon when audio is muted/unmuted. R=ben@chromium.org BUG=118116 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ash/system/audio/tray_volume.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sadrul
8 years, 9 months ago (2012-03-14 03:41:33 UTC) #1
Ben Goodger (Google)
8 years, 9 months ago (2012-03-14 16:06:42 UTC) #2
LGTM

On Tue, Mar 13, 2012 at 8:41 PM, <sadrul@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> ash: Update the volume icon when audio is muted/unmuted.
>
> R=ben@chromium.org
> BUG=118116
> TEST=none
>
>
> Please review this at
http://codereview.chromium.**org/9706007/<http://codereview.chromium.org/9706...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M ash/system/audio/tray_volume.**cc
>
>
> Index: ash/system/audio/tray_volume.**cc
> diff --git a/ash/system/audio/tray_**volume.cc b/ash/system/audio/tray_**
> volume.cc
> index 5a8e856e27b80aab79fd18f9455043**be7e847d3f..**
> 45d1d1d72f8ab5e01aaec12ac95d25**af4258779e 100644
> --- a/ash/system/audio/tray_**volume.cc
> +++ b/ash/system/audio/tray_**volume.cc
> @@ -115,6 +115,10 @@ class VolumeView : public views::View,
>
>   void SetVolumeLevel(float percent) {
>     slider_->SetValue(percent);
> +    // It is possible that the volume was (un)muted, but the actual
> volume level
> +    // did not change. In that case, setting the value of the slider won't
> +    // trigger a repaint. So explicitly trigger a repaint.
> +    icon_->SchedulePaint();
>   }
>
>  private:
>
>
>

Powered by Google App Engine
This is Rietveld 408576698