Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: runtime/bin/eventhandler_macos.cc

Issue 9705096: Add additional error printing to kqueue failures on Mac. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Better error message formatting Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/eventhandler_macos.cc
diff --git a/runtime/bin/eventhandler_macos.cc b/runtime/bin/eventhandler_macos.cc
index f93409235fbd3bdabd9326c70f732b150ed21c6a..bc5f082a1de1841a99caa3de6e7c92e10c8a2fcc 100644
--- a/runtime/bin/eventhandler_macos.cc
+++ b/runtime/bin/eventhandler_macos.cc
@@ -63,7 +63,7 @@ static void RemoveFromKqueue(intptr_t kqueue_fd_, SocketData* sd) {
int status =
TEMP_FAILURE_RETRY(kevent(kqueue_fd_, events, changes, NULL, 0, NULL));
if (status == -1) {
- FATAL("Failed deleting events from kqueue");
+ FATAL1("Failed deleting events from kqueue: %s\n", strerror(errno));
}
}
}
@@ -106,7 +106,7 @@ static void UpdateKqueue(intptr_t kqueue_fd_, SocketData* sd) {
int status =
TEMP_FAILURE_RETRY(kevent(kqueue_fd_, events, changes, NULL, 0, NULL));
if (status == -1) {
- FATAL("Failed updating kqueue");
+ FATAL1("Failed updating kqueue: %s\n", strerror(errno));
}
}
}
@@ -132,7 +132,7 @@ EventHandlerImplementation::EventHandlerImplementation()
EV_SET(&event, interrupt_fds_[0], EVFILT_READ, EV_ADD, 0, 0, NULL);
int status = TEMP_FAILURE_RETRY(kevent(kqueue_fd_, &event, 1, NULL, 0, NULL));
if (status == -1) {
- FATAL("Failed adding interrupt fd to kqueue");
+ FATAL1("Failed adding interrupt fd to kqueue: %s\n", strerror(errno));
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698