chrome/browser/printing/print_preview_tab_controller.cc - Issue 9705084: Block printing from blocked popup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_preview_tab_controller.cc

Issue 9705084: Block printing from blocked popup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix init order Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/printing/print_preview_tab_controller.cc

diff --git a/chrome/browser/printing/print_preview_tab_controller.cc b/chrome/browser/printing/print_preview_tab_controller.cc

index 01c6f226faedc4f60690fbfbebaebfe8fcc4db3e..e35f1bfa64354b34cea261e652bdb7c2a6178cf5 100644

--- a/chrome/browser/printing/print_preview_tab_controller.cc

+++ b/chrome/browser/printing/print_preview_tab_controller.cc

@@ -215,7 +215,8 @@ void PrintPreviewTabController::PrintPreview(TabContentsWrapper* tab) {

PrintPreviewTabController* tab_controller = GetInstance();

if (!tab_controller)

return;

- tab_controller->GetOrCreatePreviewTab(tab);

+ if (!tab_controller->GetOrCreatePreviewTab(tab))

+ tab->print_view_manager()->PrintPreviewDone();

}

TabContentsWrapper* PrintPreviewTabController::GetOrCreatePreviewTab(

« no previous file with comments | « no previous file | chrome/browser/printing/print_view_manager.h » ('j') | no next file with comments »