Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2581)

Unified Diff: chrome/common/extensions/manifest_unittest.cc

Issue 9705083: Unknown options in extension manifest file are silently ignored (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fixed unit test Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/manifest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/manifest_unittest.cc
diff --git a/chrome/common/extensions/manifest_unittest.cc b/chrome/common/extensions/manifest_unittest.cc
index 66cfcdcd6d5dc269bba5f0016ec34d7a3133f056..a674b4ecfc12524fe450dc01757f59e764c651da 100644
--- a/chrome/common/extensions/manifest_unittest.cc
+++ b/chrome/common/extensions/manifest_unittest.cc
@@ -68,7 +68,7 @@ TEST_F(ManifestTest, Extension) {
std::vector<std::string> warnings;
manifest->ValidateManifest(&error, &warnings);
EXPECT_TRUE(error.empty());
- EXPECT_TRUE(warnings.empty());
+ ASSERT_EQ(1u, warnings.size());
AssertType(manifest.get(), Extension::TYPE_EXTENSION);
// The known key 'background_page' should be accessible.
@@ -92,7 +92,7 @@ TEST_F(ManifestTest, Extension) {
warnings.clear();
manifest->ValidateManifest(&error, &warnings);
EXPECT_TRUE(error.empty());
- ASSERT_EQ(1u, warnings.size());
+ ASSERT_EQ(2u, warnings.size());
{
Feature feature;
feature.set_name("background_page");
« no previous file with comments | « chrome/common/extensions/manifest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698