Unknown options in extension manifest file are silently ignored

chrome/browser/resources/extensions/extension_list.js

Index: chrome/browser/resources/extensions/extension_list.js
diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js
index 873a78e3f34d559018740c3f15af3923843027fe..a909b9bf32bab30c537474a660a9466d6c010649 100644
--- a/chrome/browser/resources/extensions/extension_list.js
+++ b/chrome/browser/resources/extensions/extension_list.js
@@ -232,6 +232,17 @@ cr.define('options', function() {
         });
       }
 
+      // Then unrecognized manifest keys

[James Hawkins, 2012/04/08 20:33:23]

nit: Please turn this into a complete sentence.

[James Hawkins, 2012/04/08 20:33:23]

nit: Add a period at the end of the sentence.

[not at google - send to devlin, 2012/04/10 02:02:32]

Note that the existing comments above are already of this strange
non-complete-sentence form, so if you're going to do this then you should
probably update those too.

[mitchellwrosen, 2012/04/28 19:02:39]

Done.

[mitchellwrosen, 2012/04/28 19:02:39]

Done.

[mitchellwrosen, 2012/04/28 19:02:39]

Done.

+      if (extension.unrecognizedKeys.length > 0) {
+        var unrecognizedKeys = node.querySelector('.unrecognized-keys');
+        unrecognizedKeys.hidden = false;
+        var keys = unrecognizedKeys.querySelector('span:nth-of-type(2)');

[not at google - send to devlin, 2012/04/10 02:02:32]

Suggestion: make this an unordered list rather than a flat list of names.

[mitchellwrosen, 2012/04/28 19:02:39]

Done.

+        keys.textContent = ' ' + extension.unrecognizedKeys[0];
+        for (var i = 1; i < extension.unrecognizedKeys.length; ++i) {

[James Hawkins, 2012/04/08 20:33:23]

nit: i++

[James Hawkins, 2012/04/08 20:33:23]

nit: No braces for single-line blocks.

[not at google - send to devlin, 2012/04/10 02:02:32]

nit: use forEach here rather than a for loop

[mitchellwrosen, 2012/04/28 19:02:39]

Done.

+          keys.textContent += ', ' + extension.unrecognizedKeys[i];
+        }
+      }
+
       this.appendChild(node);
     },
   };