Unknown options in extension manifest file are silently ignored

chrome/common/extensions/manifest.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_MANIFEST_H_
 #define CHROME_COMMON_EXTENSIONS_MANIFEST_H_
 #pragma once
 
 #include <map>
 #include <string>
@@ skipping 15 matching lines @@
   virtual ~Manifest();
 
   const std::string& extension_id() const { return extension_id_; }
   void set_extension_id(const std::string& id) { extension_id_ = id; }
 
   Extension::Location location() const { return location_; }
   void set_location(Extension::Location location) { location_ = location; }
 
   // Returns true if all keys in the manifest can be specified by
   // the extension type.
-  bool ValidateManifest(string16* error) const;
+  bool ValidateManifest(string16* error);
 
   // The version of this extension's manifest. We increase the manifest
   // version when making breaking changes to the extension system. If the
   // manifest contains no explicit manifest version, this returns the current
   // system default.
   int GetManifestVersion() const;
 
   // Returns the manifest type.
   Extension::Type GetType() const;
 
@@ skipping 25 matching lines @@
   // the caller.
   Manifest* DeepCopy() const;
 
   // Returns true if this equals the |other| manifest.
   bool Equals(const Manifest* other) const;
 
   // Gets the underlying DictionaryValue representing the manifest.
   // Note: only know this when you KNOW you don't need the validation.
   base::DictionaryValue* value() const { return value_.get(); }
 
+  // Gets the list of unrecognized keys in the manifest, if any.
+  // Unrecognized keys are filled in when ValidateManifest is called.
+  bool HasUnrecognizedKeys(
+      const std::vector<const std::string*>** unrecognized_keys) const;

[not at google - send to devlin, 2012/04/09 13:01:54]

The unrecognised keys are unlikely to be a lot of data, so it'd be a cleaner
interface to just return a new std::vector<std::string> here rather than taking
it as an out-parameter.

Also, call it GetUnrecognizedKeys.

+
  private:
   // Returns true if the extension can specify the given |path|.
   bool CanAccessPath(const std::string& path) const;
   bool CanAccessKey(const std::string& key) const;
 
   // A persistent, globally unique ID. An extension's ID is used in things
   // like directory structures and URLs, and is expected to not change across
   // versions. It is generated as a SHA-256 hash of the extension's public
   // key, or as a hash of the path in the case of unpacked extensions.
   std::string extension_id_;
 
   // The location the extension was loaded from.
   Extension::Location location_;
 
   // The underlying dictionary representation of the manifest.
   scoped_ptr<base::DictionaryValue> value_;
 
+  // Unrecognized keys (e.g. "permisions": ["tabs"])
+  std::vector<const std::string*> unrecognized_keys_;

[not at google - send to devlin, 2012/04/09 13:01:54]

Make this a scoped_ptr<std::vector<std::string> > and return copies of it in
GetUnrecognizedKeys() (CHECKing that it exists first).

+
   DISALLOW_COPY_AND_ASSIGN(Manifest);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_COMMON_EXTENSIONS_MANIFEST_H_